[DV/HMAC] hmac support config blocking and wr key #1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cindychip
force-pushed
the
hmac_support_block_config
branch
2 times, most recently
from
89d10ce
to
a87041d
Compare
weicaiyang
approved these changes
Nov 20, 2019
| @@ -88,12 +88,40 @@ class hmac_base_vseq extends cip_base_vseq #(.CFG_T (hmac_env_cfg) | |||
| cfg_interrupts(.interrupts(interrupts), .enable(1'b1)); | |||
| endtask | |||
|
|
|||
| virtual task write_rand_config_and_key(bit do_wr_config, bit do_wr_key); | |||
There was a problem hiding this comment.
nit: maybe we can call it like write_discarded_config_and_key, so that we know the task just do some dummy writes. Same for write_rand_config and write_rand_key
There was a problem hiding this comment.
Thanks for the suggestion, makes sense and updated!
| @@ -184,6 +212,8 @@ class hmac_base_vseq extends cip_base_vseq #(.CFG_T (hmac_env_cfg) | |||
| if (ral.cfg.sha_en.get_mirrored_value()) begin | |||
| if (!do_back_pressure) check_status_intr_fifo_full(); | |||
| else clear_intr_fifo_full(); | |||
| // randomly change key, config regs during msg wr, should trigger error or be discarded | |||
| write_rand_config_and_key($urandom_range(0, 20) == 0, $urandom_range(0, 20) == 0); | |||
There was a problem hiding this comment.
maybe we can add some delay before write_rand_config_and_key or do it in the task
There was a problem hiding this comment.
sure, that sounds right, thanks for the reminder.
cindychip
force-pushed
the
hmac_support_block_config
branch
from
a87041d
to
729267e
Compare
weicaiyang
reviewed
Nov 20, 2019
hw/ip/hmac/dv/env/hmac_scoreboard.sv
Outdated
| // will gate the write process with wr_cnt_updated signal if user uses non-blocking mode | ||
| forever @(hmac_wr_cnt) begin | ||
| wr_cnt_updated = 0; | ||
| cfg.clk_rst_vif.wait_clks(HMAC_WR_WORD_CYCLE); |
There was a problem hiding this comment.
as discussed, looks like we can move this wait to line 246, then we can remove this loop.
There was a problem hiding this comment.
Thanks for the suggestion to simply the code. Updated as you mentioned.
cindychip
force-pushed
the
hmac_support_block_config
branch
3 times, most recently
from
aba2ff6
to
e798d1d
Compare
Support config blocking during msg_wr: during valid msg_wr, if trying to update the config register, it will be discarded Support err code when wr_key during msg_wr Separate hmac_wr_cnt in tl_process because it uses wait function Signed-off-by: Cindy Chen <chencindy@google.com>
cindychip
force-pushed
the
hmac_support_block_config
branch
from
e798d1d
to
5bac94b
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supports the changes in #1014
Support config blocking during msg_wr: during valid msg_wr, if trying to
update the config register, it will be discarded
Support err code when wr_key during msg_wr
Signed-off-by: Cindy Chen chencindy@google.com