[ci] Run more on-host tests in sw_tests #15566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Incidentally, I am the author of those uncovered test targets 🤦 |
dmcardle
added
Type:Enhancement
drewmacrae
reviewed
Oct 18, 2022
drewmacrae
approved these changes
Oct 18, 2022
dmcardle
force-pushed
the
dmcardle/expand-ci-test-coverage
branch
from
8482234
to
f309151
Compare
dmcardle
added
the
Status:Ready to merge
milesdai
approved these changes
Oct 18, 2022
drewmacrae
reviewed
Oct 19, 2022
| tags = ["verilator"], | ||
| tags = [ | ||
| "manual", | ||
| "verilator", |
There was a problem hiding this comment.
FYI, the verilator tag wasn't filtering it out of the build because --test_tag_filters doesn't affect what's built, and it's building all the targets that match the wildcard because of --build_tests_only=false
dmcardle
force-pushed
the
dmcardle/expand-ci-test-coverage
branch
from
064eda9
to
0d700f3
Compare
I noticed that a few unit test targets outside of //sw/... were not running on CI. This commit ensures that CI runs the following additional targets: * //hw/ip/rom_ctrl/util:gen_vivado_mem_image_test (after lowRISC#15163 merges) * //rules/scripts:bitstreams_workspace_test * //util:generate_compilation_db_test Signed-off-by: Dan McArdle <dmcardle@google.com>
Signed-off-by: Dan McArdle <dmcardle@google.com>
dmcardle
force-pushed
the
dmcardle/expand-ci-test-coverage
branch
from
0d700f3
to
e953cf4
Compare
|
Oops. I originally added these two lines: + -//quality/...\
+ -//third_party/riscv-compliance/... \Because (a) there was no whitespace between |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that a few unit test targets outside of //sw/... were not running on CI.
This commit ensures that CI runs the following additional targets:
Signed-off-by: Dan McArdle dmcardle@google.com