[sca/WIP] Update the ecdsa384_sca code

[bilgiday]

Update ecc384_serial.c and p384_ecdsa_sca.s files to be compatible with the latest capture.py file in the ot-sca repo.

This is an WIP PR.

[bilgiday]

@wettermo, @jadephilipoom,

I modified these two files based on the p256_serial.c file in th OT-repo, and the p384_ecdsa_sign_test.s file in the PR #19290.

I was able to compile the files using #19290. @wettermo, you can use them in your local environment and test if they work with the ot-sca tooling.

[wettermo]

Thanks a lot @bilgiday ! I'll keep you updated on my progress :) .

[wettermo]

LGTM! I tested the changes on my PC/FPGA setup: no errors and compatible with capture.py in ot-sca repository.
Thanks a lot @bilgiday !!

[bilgiday]

@wettermo Thanks for checking it!

@jadephilipoom, It looks like the CI checks also pass now. If it looks okay to you, we can merge this. WDYT?

[vrozic]

Thanks @bilgiday for working on this. The code looks good to me, modulo comment from @wettermo.

We can update the binaries in ot-sca once this is merged. For now, I've opened ot-sca Issue 149 so we don't forget.

[bilgiday]

@vrozic Great, thanks for opening the ot-sca-issue. I will update the binaries after this PR is merged.

[vogelpi]

This PR is a bit older than a month an in attempt to move things forward, I've taken the liberty to rebase this on current master.

[vogelpi]

Update: I've now also included the change suggested by @wettermo and fixed some more comments referring to P256 as well as a missing factor of two (was missing already before). I will now approve this PR and merge it once CI passes.

[vogelpi]

LGTM, thanks for updating these apps @bilgiday !

[jadephilipoom]

Belated LGTM from me 🙂