[cherrypick, rom, rom_ext] Re-arrange retention RAM #21587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfrantz
changed the title
cfrantz
force-pushed
the
master-retram
branch
from
f81dd22
to
7735c38
Compare
moidx
approved these changes
Feb 21, 2024
cfrantz
force-pushed
the
master-retram
branch
from
7735c38
to
77d7f4c
Compare
timothytrippel
approved these changes
Feb 22, 2024
milesdai
approved these changes
Feb 22, 2024
Re-arrange the RET-RAM to be more amenable to future expansions.
1. Expand the boot_log to 128 bytes. Include the ROM_EXT version number
and the nonce value required by owner-authenticated boot_svc commands.
2. Expand the boot_svc message size to 256 bytes. Many of the future
ownership transfer commands will be larger than the current size.
3. Re-order the retention-RAM layout.
- Move the `last_shutdown_reason` immediately after the `reset_reason`.
- Place `boot_log` after `last_shutdown_reason`.
- Place the `boot_svc_msg` at the end of the creator portion of
RET-RAM.
This arrangement allows us to add additional items in the middle
reserved portion of the struct and to optionally expand the
boot_svc_msg to a larger size without disrupting the locations of any
of the prior members.
Signed-off-by: Chris Frantz <cfrantz@google.com>
Re-arrange the retention RAM as discussed in the SW WG meeting on 2024-02-13: Locate the boot_svc message first, followed by reserved space, followed by the boot_log and last_shutdown_reason. This arrangement allows us to grow the boot_svc message (growing "down" into the reserved space) if needed and to add additional fields at the end (growing "up" into the reserved space). Also: name the ASCII code for boot log as `BLOG` instead of `BOLG`. Signed-off-by: Chris Frantz <cfrantz@google.com>
cfrantz
force-pushed
the
master-retram
branch
from
77d7f4c
to
d031d26
Compare
cfrantz
added a commit
to cfrantz/opentitan
that referenced
this pull request
Apr 2, 2024
A signing ceremony was performed to sign the following items: - Personalization binaries. - The ProdA, ProdC and SiVal ROM_EXTs. The ROM_EXT contains the rescue protocol and the RET-RAM struct re-arrangements from lowRISC#21587. The binaries contained in this PR were built at git commit 39cf48b. Signed-off-by: Chris Frantz <cfrantz@google.com>
cfrantz
added a commit
to cfrantz/opentitan
that referenced
this pull request
Apr 2, 2024
A signing ceremony was performed to sign the following items: - Personalization binaries. - The ProdA, ProdC and SiVal ROM_EXTs. The ROM_EXT contains the rescue protocol and the RET-RAM struct re-arrangements from lowRISC#21587. The binaries contained in this PR were built at git commit 39cf48b. Signed-off-by: Chris Frantz <cfrantz@google.com>
timothytrippel
pushed a commit
that referenced
this pull request
Apr 3, 2024
A signing ceremony was performed to sign the following items: - Personalization binaries. - The ProdA, ProdC and SiVal ROM_EXTs. The ROM_EXT contains the rescue protocol and the RET-RAM struct re-arrangements from #21587. The binaries contained in this PR were built at git commit 39cf48b. Signed-off-by: Chris Frantz <cfrantz@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-arrange the retention RAM as discussed in the SW WG meeting on
2024-02-13:
Locate the boot_svc message first, followed by reserved space, followed
by the boot_log and last_shutdown_reason. This arrangement allows us
to grow the boot_svc message (growing "down" into the reserved space)
if needed and to add additional fields at the end (growing "up" into
the reserved space).
Also: name the ASCII code for boot log as
BLOGinstead ofBOLG.