KMAC support for Python scripts #54
Conversation
There was a problem hiding this comment.
Thanks @m-temp for your first PR to ot-sca! ;-)
At the moment, it's not fully clear to me what code is from XKCP and what code you contributed yourself, i.e., where I should focus with my review. I suggest that you try to use the OpenTitan vendor tool for including the XKCP sources and then things become more obvious for me and I can do a second pass.
Please just let me know if things are not clear or you need some help.
There was a problem hiding this comment.
I reworked the code as suggested. However, I need to place this single config file in the vendor directory, or patch all files to use a different location.
What's the best way to do it?
I tried to use the patch_dir config option, however it seems like the patch_dir can only be used for "real" patches, but not for creating files. CRITICAL: In hjson at cw/cw305/vendor/xkcp_xkcp.vendor.hjson, Has patch_dir, but no mapping item uses it.
As this file is needed by my build script I could dynamically create it during compile time. This would be similar to the upstream project where this file is created in the makefile.
There was a problem hiding this comment.
Thanks for updating this PR and using the vendor tool @m-temp . I've left some comments around formatting and linting + some other stuff. But this is definitely going in the right direction.
One general comment: Since this is a PR, it is completely fine to fixup/squash commits and do force push. Ultimately, this PR should have one or two commits.
There was a problem hiding this comment.
Thanks @m-temp for addressing the feedback. I had to read up a bit on the __init__.py topic and I think calling the build function inside that is how this should be done. Sorry for raising this point in the first place. I also forgot to answer your question on the handling of the config file in the vendor dir. The solution you came up with looks okay to me, too.
Other than a couple of nits in the readme, this looks good to me, thanks for your work on this!
Most of the source and header files of the XKCP are released to the public domain and associated to the CC0 deed. The exception is brg_endian.h which is copyrighted by Brian Gladman and comes with a BSD 3-clause license; Signed-off-by: Michael Tempelmeier <michael.tempelmeier@gi-de.com>
|
This looks good, I've successfully tested this and integrated it into the capture (will file a PR shortly). I am merging this. Congrats @m-temp to your first PR :-) |
This is WIP to add KMAC (and cshake) support to the SCA-repo.
Unfortunately, there is no (native) support for kmac and cshake (mainly because of the customization string in SP800-185) in python. There is a feature request for hashlib, but to the best of my knowledge there is no SP800-185 python module available. Therefore I used the standard (other optimizations would be possible) C-implementation from the official eXtended Keccak Code Package which uses the CC0 and a BSD 3-clause license. Is this OK?
The provided demo works for the testvektors and are compatible to cw's ktp-generator.
As I'm waiting for a cw310 board I cannot integrate the code into the ot-sca-framework atm.
However this pull request is intended to further discuss the implementation process. Help on how to integrate the cffi, ffi/lib stuff into a package is welcome. Apologies, if I missed things in the integration flow. Please bear with me, I'm new ;)