TVLA: Test histogram loading for general tests #95
Conversation
andreaskurth
force-pushed
the
test-tvla_hist_load
branch
from
46e04b1
to
a71686d
Compare
andreaskurth
force-pushed
the
test-tvla_hist_load
branch
2 times, most recently
from
b7c836e
to
037938b
Compare
Signed-off-by: Andreas Kurth <adk@lowrisc.org>
andreaskurth
force-pushed
the
test-tvla_hist_load
branch
from
037938b
to
d162094
Compare
andreaskurth
requested review from
abdullahvarici,
alphan and
vogelpi
as code owners
|
After we get some power measurements with capture.py script, we don't get the histogram files, right? I think we also need to add some other tests to cover the complete functionality of the tvla.py script (input may be hundreds of power traces and output may be the figures or their hashes). Other than that, it worked in my system and looks good to me. In my PR, I have changed the commands in tvla_test.py to comply with the updated CLI of the tvla.py script: #92 |
This class represents the absolute path to a test data file. This serves two main purposes: 1. All test data files live in the same subdirectory, and this class encapsulates that commonality. 2. Canonically using an absolute path to access test data decouples the current working directory where a test is executed from the test result. Signed-off-by: Andreas Kurth <adk@lowrisc.org>
andreaskurth
force-pushed
the
test-tvla_hist_load
branch
from
d162094
to
5814683
Compare
Absolutely, this is just the first step in testing the full TVLA! Could you create an issue to collect aspects of TVLA that need testing, @abdullahvarici? We can then discuss and prioritize them together.
Great, thanks!
Nice, let's focus on getting that merged as soon as this is approved and merged. |
This adds two tests: each test takes a histogram as input, runs TVLA on it, and checks whether the resulting t-test traces contains a significant deviation from the mean, which would indicate leakage. For one histogram we expect leakage, for the other we do not. These tests are automatically discovered by pytest. Run `pytest test` in the top-level directory to execute them. Signed-off-by: Andreas Kurth <adk@lowrisc.org>
andreaskurth
force-pushed
the
test-tvla_hist_load
branch
from
5814683
to
074d9bb
Compare
This tests the functionality implemented in #89.