Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure Pipelines: Give contributors access to build log #71

Closed
imphil opened this issue Apr 3, 2019 · 5 comments
Closed

Azure Pipelines: Give contributors access to build log #71

imphil opened this issue Apr 3, 2019 · 5 comments
Labels
Component:Tooling Issues related to tooling, e.g. tools/scripts for doc, code generation (docgen, reggen), CSR Priority:P3 Priority: low Type:Enhancement Feature requests, enhancements

Comments

@imphil
Copy link
Contributor

imphil commented Apr 3, 2019

Currently this repository and the Azure Pipelines builds are "private", which means failing PRs only show a single line of (rather useless) build output. Since Azure Pipelines doesn't support syncing the team permissions from GitHub we need to manually add users with write permissions to stwg-base also to Azure Pipelines.

For now, if you want to see the full CI build log, please drop me a mail with your Microsoft or Skype account name. I'll add you to the right group.

If we want to go fancy (and have time), we can explore a couple more options:

  • It seems the GitHub checks API and the Azure Pipelines integration is rather new and we could open an issue with the pipelines team to see if they can add more information to the build status through the GitHub Checks API.
  • We could have the CI job itself post the failing build status to the PR as comment.

Or we could just wait until we go public or choose another CI solution and the permission problems vanish.

@asb
Copy link
Member

asb commented Apr 3, 2019

As Azure Pipelines is meant to be a stopgap solution, the stopgap solution you propose (adding active contributors manually) to this limitation seems the best approach for the time being.

Maybe with the GitHub acquisition, Azure Pipelines will gain the ability to do oauth with GitHub, allowing team access permissions (just like bubble.servers.lowrisc.org does for the docs).

@aytong aytong assigned imphil and unassigned imphil Apr 17, 2019
@imphil
Copy link
Contributor Author

imphil commented May 6, 2019

As expected after the GitHub acquisition, things are getting better integrated. Soon a GitHub account will allow users to log in to Azure, as announced today in https://azure.microsoft.com/en-gb/blog/accelerating-devops-with-github-and-azure/

Sign in to Azure and Azure DevOps with your GitHub account

We also know there are a lot of developers who have GitHub personal accounts and don’t have a Microsoft managed identity. We’re also excited to announce that GitHub users will be able to sign in to Azure and Azure DevOps using an existing GitHub account later this week. Just go to the Azure portal or Azure DevOps page and click the GitHub icon to login. This integration makes it even easier for developers to go from code to cloud.

It's likely that GitHub group support comes soon as well. So I'm not planning to do anything on our side for now.

@lowrisc-bot lowrisc-bot transferred this issue from another repository Aug 31, 2019
@lowrisc-bot lowrisc-bot added Component:Tooling Issues related to tooling, e.g. tools/scripts for doc, code generation (docgen, reggen), CSR Priority:P3 Priority: low Resolve: Migrate to OT Type:Enhancement Feature requests, enhancements labels Aug 31, 2019
@aytong
Copy link

aytong commented Oct 31, 2019

Scrubbing stale issues. @imphil , have they enabled this capability yet?

@imphil
Copy link
Contributor Author

imphil commented Oct 31, 2019

no

@imphil
Copy link
Contributor Author

imphil commented Nov 7, 2019

https://dev.azure.com/lowrisc/opentitan is now public, all build results are visible there.

@imphil imphil closed this as completed Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component:Tooling Issues related to tooling, e.g. tools/scripts for doc, code generation (docgen, reggen), CSR Priority:P3 Priority: low Type:Enhancement Feature requests, enhancements
Projects
None yet
Development

No branches or pull requests

4 participants