Relationships don't construct cache keys correctly

[harto]

The cache key is incorrectly constructed in BelongsTo::get() and HasOne::get().

In BelongsTo::get(), the cache key is constructed something like this:

$schema = \Pheasant::instance()->schema($this->class);
$cacheKey = $schema->hash($object, array($this->foreign));

Using an example from the test suite:

• $object is an instance of Hero
• $this->class is the class of the related object, i.e. SecretIdentity
• $this->foreign is the name of SecretIdentity's primary key column, e.g. id.

For a Hero with id = 1 and identityid = 2, the above code will generate a cache key of SecretIdentity[id=1] instead of SecretIdentity[id=2].

I believe the test suite is only passing because the sequences table is wiped each time, and so each Hero->id always matches SecretIdentity->id.

[harto]

Ping @lox -- I'm not really sure how to approach this one.

[lox]

Ok cool, I'll see what I can do. Any chance you could commit a failing testcase to a branch?

[bjornpost]

@lox: I guess the testcase in #105 is still up-to-date. Let me know if I can test anything (or help with something else).

[harto]

This is a slightly simpler failing test: 1d0632d

[bjornpost]

Any progression on this? Maybe we can start preparing a 1.4 release which introduces include(), Scopes and $allowEmpty for BelongsTo. I've also been working on and off improving the docs, making sure all concepts are explained again.

[bjornpost]

@lox is there any progress on this? Is there anything I can do to help speed things up?

[Jud]

We fixed this here:
https://github.com/judsonco/pheasant/blob/dc2ea2ed70bb0ea65903e67cfd6c0943b2a6a06a/lib/Pheasant/Relationships/HasOne.php#L36
and
https://github.com/judsonco/pheasant/blob/3c0a98618f24ef9bfb69d0d5a7517a007183692a/lib/Pheasant/Schema.php#L65-L79

The fix was narrow for our use case, so ymmv.

[bjornpost]

Cool! Would you mind testing this against the test in 1d0632d?

[lox]

If this fixes the issues, I'll merge and release promptly.

[Jud]

Fixed in #126