Start cleaning up I2C code #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This follows the example set in `usart` and other modules. It's not strictly necessary (`i2c` is a relatively small module), but I think it's still an improvement.
I always like to put inherent impls before trait implementations. Following this rule consistently makes the code a bit more readable, I believe.
This prevents a name collision that would have been caused by a change I'm currently working on.
I don't see a reason to tie an I2C clock configuration to a specific instance. All it does is prevent re-use of the clock configuration for several I2C instances.
david-sawatzke
approved these changes
May 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR starts cleaning up the I2C module, specifically the clock configuration. It follows the example of the USART cleanup in #223.
I'm not done yet, but the work done here is already an improvement on its own.