Skip to content

Commit

Permalink
Removed the use of -commons linking option on Darwin (HDFGroup#3581)
Browse files Browse the repository at this point in the history
Removed the use of -commons linking option on Darwin as COMMON and EQUIVALENCE is no long used
  • Loading branch information
brtnfld authored and lrknox committed Sep 29, 2023
1 parent 9f00c09 commit a7558cc
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 11 deletions.
8 changes: 0 additions & 8 deletions configure.ac
Original file line number Diff line number Diff line change
Expand Up @@ -1077,14 +1077,6 @@ H5_FORTRAN_SHARED="no"
if test "X${HDF_FORTRAN}" = "Xyes" && test "X${enable_shared}" != "Xno"; then
AC_MSG_CHECKING([if shared Fortran libraries are supported])
H5_FORTRAN_SHARED="yes"
## tell libtool to do the right thing with COMMON symbols, this fixes
## corrupt values with COMMON and EQUIVALENCE when building shared
## Fortran libraries on OSX with gnu and Intel compilers (HDFFV-2772).
case "`uname`" in
Darwin*)
H5_LDFLAGS="$H5_LDFLAGS -Wl,-commons,use_dylibs"
;;
esac

## Report results of check(s)

Expand Down
2 changes: 0 additions & 2 deletions fortran/src/H5f90global.F90
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@
! PURPOSE
! This module is used to pass C stubs for H5 Fortran APIs. The C stubs are
! packed into arrays in H5_f.c and these arrays are then passed to Fortran.
! This module then uses EQUIVALENCE to assign elements of the arrays to
! Fortran equivalent C stubs.
!
! NOTES
! The size of the C arrays in H5_f.c has to match the values of the variables
Expand Down
5 changes: 4 additions & 1 deletion release_docs/RELEASE.txt
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,10 @@ New Features

Fortran Library:
----------------
-
- Removed "-commons" linking option on Darwin, as COMMON and EQUIVALENCE
are no longer used in the Fortran source.

Fixes GitHub issue #3571


C++ Library:
Expand Down

0 comments on commit a7558cc

Please sign in to comment.