Upgraded log4j2 to the up-to-date release.

Extracted constant in pom.xml
lrozenblyum · Oct 24, 2015 · 7b649d1 · 7b649d1
1 parent 64d3fbe
commit 7b649d1
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/Chess.iml b/Chess.iml
@@ -16,8 +16,8 @@
     </content>
     <orderEntry type="jdk" jdkName="1.8" jdkType="JavaSDK" />
     <orderEntry type="sourceFolder" forTests="false" />
-    <orderEntry type="library" name="Maven: org.apache.logging.log4j:log4j-api:2.1" level="project" />
-    <orderEntry type="library" scope="RUNTIME" name="Maven: org.apache.logging.log4j:log4j-core:2.1" level="project" />
+    <orderEntry type="library" name="Maven: org.apache.logging.log4j:log4j-api:2.4.1" level="project" />
+    <orderEntry type="library" scope="RUNTIME" name="Maven: org.apache.logging.log4j:log4j-core:2.4.1" level="project" />
     <orderEntry type="library" scope="TEST" name="Maven: junit:junit:4.11" level="project" />
     <orderEntry type="library" scope="TEST" name="Maven: org.hamcrest:hamcrest-core:1.3" level="project" />
     <orderEntry type="library" scope="TEST" name="Maven: org.mockito:mockito-core:1.9.5" level="project" />

diff --git a/pom.xml b/pom.xml
@@ -3,6 +3,7 @@
          xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
          xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
     <modelVersion>4.0.0</modelVersion>
+
     <name>Chess</name>
     <groupId>com.leokom</groupId>
     <artifactId>Chess</artifactId>
@@ -19,13 +20,13 @@
         <dependency>
             <groupId>org.apache.logging.log4j</groupId>
             <artifactId>log4j-api</artifactId>
-            <version>2.1</version>
+            <version>${log4j2version}</version>
         </dependency>
 
         <dependency>
             <groupId>org.apache.logging.log4j</groupId>
             <artifactId>log4j-core</artifactId>
-            <version>2.1</version>
+            <version>${log4j2version}</version>
             <!-- I like keeping scope as more precise as possible
             However log4j2 developers say that making it compile
             may improve performance for custom plugins
@@ -135,5 +136,9 @@
     <properties>
         <!-- Preventing [WARNING] Using platform encoding to copy filtered resources -->
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
+
+
+        <!-- Naming convention inspired by http://stackoverflow.com/a/30318342/1429367 -->
+        <log4j2version>2.4.1</log4j2version>
     </properties>
 </project>