Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IRC color code bug #24

Merged
merged 2 commits into from
Nov 14, 2018
Merged

Fix IRC color code bug #24

merged 2 commits into from
Nov 14, 2018

Conversation

cyruslabs
Copy link
Contributor

Fix IRC color bug preventing some color codes (e.g cyan) from formatting properly.

Test pass after fix:
=== RUN TestFormat
--- PASS: TestFormat (0.00s)
PASS

@codecov-io
Copy link

codecov-io commented Nov 14, 2018

Codecov Report

Merging #24 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #24   +/-   ##
=======================================
  Coverage   56.16%   56.16%           
=======================================
  Files          13       13           
  Lines        2329     2329           
=======================================
  Hits         1308     1308           
  Misses        913      913           
  Partials      108      108
Impacted Files Coverage Δ
format.go 97.16% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2816e42...9da2a33. Read the comment docs.

@lrstanley
Copy link
Owner

Nice catch, surprised I didn't see this before. Can you add an additional entry to TestFormat that includes using cyan?

@cyruslabs
Copy link
Contributor Author

Sure, just updated the branch adding red and cyan tests (one was working before and the other wasn't).

Thanks for this great project by the way! Much appreciated.

@lrstanley lrstanley merged commit 3aee8c2 into lrstanley:master Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants