-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add kubernetes proxy #44
Conversation
Hello, Output log on a vault cluster with 3 nodes, 5 unseal keys (3 keys required) :
The documentation needs to be updated, but I'll do it once the code is stable. |
I need to handle discovery better, as autodiscovery is only executed at vault-unseal startup. |
Okay, I think we're good for a first review. I've removed the pod discovery feature because it's rather pointless. When using retry_join, you need to write a static configuration in a ConfigMap for Vault, or you have to use the raft join command (so you know how many Vault pods you have). Additionally, it's not suitable because when a pod (Vault node) is down, you can't detect it during the unseal process as a basic discovery won't see it. |
Hello @lrstanley, |
Signed-off-by: Ludovic Ortega <ludovic.ortega@adminafk.fr>
🚀 Changes proposed by this PR
🔗 Related bug reports/feature requests
🧰 Type of change
📝 Notes to reviewer
🤝 Requirements