Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/88 minor ui issues #89

Merged
merged 4 commits into from
Mar 26, 2020
Merged

Bugfix/88 minor ui issues #89

merged 4 commits into from
Mar 26, 2020

Conversation

TobiasPr
Copy link
Contributor

@TobiasPr TobiasPr commented Mar 19, 2020

Checklist

  • I documented the TypeScript code using JSDoc style.
  • I added multiple screenshots/screencasts of my UI changes
  • I translated all the newly inserted strings into German and English

Motivation and Context

Fix for #88 + We want more users to report their issues with Apollon so that we can improve

Description

Changes as requested in issue
Does not work for Firefox, just for chrome so far. We will change that when we include a proper framework for the standalone version (right now vanilla javascript + html + css)

Steps for Testing

  1. select diagram type which is too long for dropdown and check if dropdown adapts
  2. select diagram type "Component Diagram" and check if interface preview is correct

Component-Diagram Interface Preview

Screenshots

Dropdown + read-only field
minor_bugs_interface

Dropdown + read-only field
ui_minor_bugs_dropdown_read_only

@TobiasPr TobiasPr linked an issue Mar 19, 2020 that may be closed by this pull request
@alextsakpinis
Copy link

Seems good, great job!

@TobiasPr TobiasPr merged commit 9b001de into develop Mar 26, 2020
@krusche krusche deleted the bugfix/88_Minor_UI_Issues branch March 26, 2020 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI] Minor UI Issues
3 participants