Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide "Start new assessment" button in Tutor Exercise Dashboard #1611

Merged

Conversation

madwau
Copy link
Contributor

@madwau madwau commented Jun 9, 2020

Checklist

  • I tested all changes and all related features with different users (student, tutor, instructor, admin) on the test server https://artemistest.ase.in.tum.de.
  • Client: I added multiple screenshots/screencasts of my UI changes
  • Client: I translated all the newly inserted strings into German and English

Motivation and Context

This PR addresses this issue.

Description

  1. Hide row to start a new assessment in the Tutor Exercise Dashboard for Team Exercises
  2. If the tutor has no assessments yet for a team exercise, show an info box in the location where assessments are started for individual exercises that informs the tutor that assessments are started elsewhere for team exercises (see screenshot below). This should only be seen in very rare cases though since there is now no longer a way to navigate to the Tutor Exercise Dashboard for team exercises via the UI (since the back button no longer redirects the user there).
  3. The back button on assessments should lead back to the team page for team exercises (instead of to the Tutor Exercise Dashboard)
  4. Perform server-side check if starting assessment is allowed for team exercise also if no result exists yet
  5. The "Start new assessment" button on the team page should not be disabled even when the assessment due date has passed. It must be possible for tutors to assess submissions even when they missed the deadline since the teams need to receive an assessment (this is also allowed server-side). This issue was reported by @julian-christl.

Steps for Testing

  1. Log in to Artemis
  2. Navigate to Course Management
  3. Click on Tutor Course Dashboard (for a course with team exercises)
  4. Click on the button "Exercise Teams" for a team exercise
  5. Click on the short name of one of the teams
  6. Make sure that team has a submission for that exercise
  7. Click on the yellow button "Start Assessment" (or "Continue Assessment")
  8. Click on the back arrow at the top left and make sure that it redirects back to the team page (and NOT to the tutor exercise dashboard)

Screenshots

OnPaste 20200609-182651

@madwau madwau self-assigned this Jun 9, 2020
@madwau madwau linked an issue Jun 9, 2020 that may be closed by this pull request
@artemis-bot artemis-bot added this to In progress in Artemis Development Jun 9, 2020
@github-actions github-actions bot added client Pull requests that update TypeScript code. (Added Automatically!) server Pull requests that update Java code. (Added Automatically!) labels Jun 9, 2020
@madwau madwau added this to the 4.2.0 milestone Jun 9, 2020
…llowed server side). Issue of disabled button in this state was found by Julian Christl.
@madwau madwau marked this pull request as ready for review June 9, 2020 18:26
@madwau madwau requested review from jpbernius, krusche and a team as code owners June 9, 2020 18:26
@madwau madwau requested a review from F4lka June 9, 2020 18:26
@artemis-bot artemis-bot moved this from In progress to Ready for review in Artemis Development Jun 9, 2020
@madwau madwau requested a review from TobiasPr June 9, 2020 18:27
@florian-glombik florian-glombik self-requested a review June 9, 2020 19:15
Copy link
Contributor

@florian-glombik florian-glombik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The back button seems to be broken as well as the continue-assessment button when assessing text exercises.

I have tested it so far for text exercises and modeling exercises. With bought exercises, I've had the same problem.

Text Exercise Assessment:
teamExercise-backButtonNotWorking

Browser: Google Chrome 83.0.4103.97
OS: Windows 10 Pro

Artemis Development automation moved this from Ready for review to Review in progress Jun 9, 2020
TobiasPr
TobiasPr previously approved these changes Jun 9, 2020
Copy link
Contributor

@TobiasPr TobiasPr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, good job 👍

@TobiasPr
Copy link
Contributor

TobiasPr commented Jun 9, 2020

The back button seems to be broken as well as the continue-assessment button.

teamExercise-backButtonNotWorking

Intresting, for me it's working (I tested modeling exercises)...
Update: It also worked for me for Text Exercises, but when I click Cancel in Text Exercise Assessment the browser navigates back to the Tutor Exercise Dashboard for

@TobiasPr TobiasPr dismissed their stale review June 9, 2020 19:40

found a bug afterwards

@TobiasPr
Copy link
Contributor

TobiasPr commented Jun 9, 2020

There is also different behavior for modeling exercises and text exercises
Modeling Exercises:
modeling_exercises

Text Exercises
text_exercises

@madwau
Copy link
Contributor Author

madwau commented Jun 9, 2020

Thanks @florian-glombik and @TobiasPr.

I fixed the disabled "Continue assessment" button.

Good finding with the cancel button redirecting to the tutor dashboard for text exercises. Somehow this is slightly different than the modeling and file upload assessment component in that it has the route hardcoded for the cancel redirect. Will fix it. Edit: Fixed now.

@TobiasPr TobiasPr self-requested a review June 9, 2020 20:25
@florian-glombik
Copy link
Contributor

florian-glombik commented Jun 9, 2020

Continue Assessment works for me now.

The back button has a very strange behaviour:
instructor: the back button works
backButtonWorkingForInstructor

tutor: the back button doesn't work
backButtonNotWorkingForTutor

Browser: Google Chrome 83.0.4103.97
OS: Windows 10 Pro

@TobiasPr
Copy link
Contributor

TobiasPr commented Jun 9, 2020

Mh weird, still working for me as tutor and as instructor. For file upload, modeling and text exercises.

TobiasPr
TobiasPr previously approved these changes Jun 9, 2020
Copy link
Contributor

@TobiasPr TobiasPr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me as instructor and as tutor for text, modeling and file upload exercises

jpbernius
jpbernius previously approved these changes Jun 9, 2020
@madwau madwau dismissed stale reviews from jpbernius and TobiasPr via d4e135e June 9, 2020 21:16
@krusche krusche merged commit 4710647 into develop Jun 9, 2020
Artemis Development automation moved this from Review in progress to Done Jun 9, 2020
@krusche krusche deleted the bugfix/team-exercises/assessment-button-still-visible branch June 9, 2020 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug client Pull requests that update TypeScript code. (Added Automatically!) component:Team server Pull requests that update Java code. (Added Automatically!)
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

"Start new assesment" button still visible for team exercises.
5 participants