Development: Refactor bad code smell in list to array conversion
#5885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ToArrayCallWithZeroLengthArrayArgument The performance of the empty array version is the same, and sometimes even better, compared to the pre-sized version. Also, passing a pre-sized array is dangerous for a concurrent or synchronized collection as a data race is possible between the <code>size</code> and <code>toArray</code> calls. This may result in extra <code>null</code>s at the end of the array if the collection was concurrently shrunk during the operation.</p> See https://shipilev.net/blog/2016/arrays-wisdom-ancients/ for more details.
github-actions
bot
added
the
server
Strohgelaender
changed the title
Development: refactor bad smell ToArrayCallWithZeroLengthArrayArgument
Strohgelaender
requested changes
Nov 25, 2022
There was a problem hiding this comment.
According to your own tool there are more instances of this code smell in the source code, e.g. in ConversationService.java:79. It would be great if you could adress all of them in one PR.
Codecov ReportBase: 75.63% // Head: 79.92% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #5885 +/- ##
=============================================
+ Coverage 75.63% 79.92% +4.28%
- Complexity 0 12354 +12354
=============================================
Files 1117 2125 +1008
Lines 44289 84225 +39936
Branches 8364 12633 +4269
=============================================
+ Hits 33499 67313 +33814
- Misses 5621 9385 +3764
- Partials 5169 7527 +2358
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
src/main/java/de/tum/in/www1/artemis/service/metis/ConversationService.java
Outdated
Show resolved
Hide resolved
…nService.java Co-authored-by: Lucas Welscher <micky.321@web.de>
Strohgelaender
previously approved these changes
Nov 26, 2022
Strohgelaender
previously approved these changes
Nov 26, 2022
Strohgelaender
approved these changes
Nov 26, 2022
JohannesStoehr
approved these changes
Nov 27, 2022
tobias-lippert
approved these changes
Nov 27, 2022
krusche
changed the title
Development: refactor bad smell ToArrayCallWithZeroLengthArrayArgumentDevelopment: Refactor bad code smell in list to array conversion
Strohgelaender
had a problem deploying
to
artemistest5
GitHub Actions
Failure
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repairing Code Style Issues
ToArrayCallWithZeroLengthArrayArgument
The performance of the empty array version is the same, and sometimes even better, compared
to the pre-sized version. Also, passing a pre-sized array is dangerous for a concurrent or
synchronized collection as a data race is possible between the
sizeandtoArraycalls. This may result in extra
nulls at the end of the array if the collection was concurrentlyshrunk during the operation.
See https://shipilev.net/blog/2016/arrays-wisdom-ancients/ for more details.
Repairing Code Style Issues