-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Programming exercises
: Speedup archival
#7165
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
tests
server
Pull requests that update Java code. (Added Automatically!)
labels
Sep 9, 2023
src/main/java/de/tum/in/www1/artemis/service/programming/ProgrammingExerciseExportService.java
Outdated
Show resolved
Hide resolved
Strohgelaender
previously approved these changes
Sep 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code lgtm
src/main/java/de/tum/in/www1/artemis/service/programming/ProgrammingExerciseExportService.java
Outdated
Show resolved
Hide resolved
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Archiving programming exercises as part of a course or exam was done sequentially which can take quite some time, especially in courses with between 10.000 and 80.000 repositories (such as on the TUM production system).
This PR speeds up the process by running the clone and zip operation in 10 parallel threads. In a local test, the archival time of one course was around 5-7x faster with this approach.
Checklist
General
Server
Steps for Testing
Prerequisites:
Code Review
Manual Tests