Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development: Use GitHub to build coverage tables #8485

Merged
merged 26 commits into from
May 28, 2024

Conversation

undernagruzez
Copy link
Contributor

@undernagruzez undernagruzez commented Apr 27, 2024

Checklist

General

Motivation and Context

Bamboo is used as source for the coverage artifacts. Now, Github will upload the artifacts too and the script will use them.

Description

The 'Test' workflow has been adapted. 'generate_code_cov_table.py' has been adapted.

Steps for Testing

This PR is difficult to test as there are no code changes and therefore no test coverage. But, I didn't change the part related to generation of the coverage table. Follow the rules described in supporting_scripts/generate_code_cov_table/README.md and make sure no error is thrown. Important: this branch should be active.

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked






Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

@undernagruzez undernagruzez marked this pull request as ready for review April 27, 2024 00:42
@undernagruzez undernagruzez requested a review from a team as a code owner April 27, 2024 00:42
Copy link

coderabbitai bot commented Apr 27, 2024

Warning

Rate Limit Exceeded

@undernagruzez has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 21 minutes and 17 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between af0c90e and 0b320c2.

Walkthrough

The recent updates focus on transitioning the code coverage report generation and uploading processes from Bamboo to GitHub. The GitHub Actions workflow now includes steps to upload server and client test coverage reports. The supporting script for generating the coverage table has been refactored to interact with GitHub, requiring a GitHub token for authentication instead of Bamboo credentials. This involves changes in environment variable names, script arguments, and the addition of new functions to handle GitHub API interactions.

Changes

File Path Summary
.github/workflows/test.yml Added steps to upload server and client test coverage reports in the GitHub Actions workflow.
supporting_scripts/generate_code_cov_table/README.md Updated instructions to use GitHub token instead of Bamboo credentials and changed script arguments.
supporting_scripts/generate_code_cov_table/env.example Renamed environment variables from BAMBOO_USERNAME and BAMBOO_PASSWORD to TOKEN.
supporting_scripts/generate_code_cov_table/generate_code_cov_table.py Refactored script to interact with GitHub for coverage data, added functions for downloading, extracting, and processing coverage artifacts.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 5

undernagruzez and others added 5 commits April 27, 2024 02:54
…able.py

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
…able.py

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

supporting_scripts/generate_code_cov_table/README.md Outdated Show resolved Hide resolved
supporting_scripts/generate_code_cov_table/README.md Outdated Show resolved Hide resolved
coderabbitai[bot]
coderabbitai bot previously approved these changes Apr 27, 2024
@FelixTJDietrich FelixTJDietrich self-requested a review April 29, 2024 08:31
@FelixTJDietrich FelixTJDietrich changed the title Development Use Github to build coverage tables Development: Use Github to build coverage tables Apr 29, 2024
Hialus
Hialus previously approved these changes Apr 29, 2024
Copy link
Member

@Hialus Hialus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and I ran it locally, though that is obviously an imperfect test, without any data. Do you have any PR that you could base on top of this, so we have a realistic example? Could also just be a test PR.

I left 2 small nitpick comments that you may want to implement.

@undernagruzez
Copy link
Contributor Author

Do you have any PR that you could base on top of this, so we have a realistic example?

Thanks for your review @Hialus. I have a currently open PR, but it has to be merged soon. I'll open another PR soon, whose review should take assumingly longer than this one, so unnecessary diff will be gone, I'll let you know.

Copy link
Contributor

@rstief rstief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, just two small comments.

…able.py

Co-authored-by: Timor Morrien <timor.morrien@tum.de>
@undernagruzez undernagruzez dismissed stale reviews from Hialus and coderabbitai via 4b22b09 May 5, 2024 11:15
…able.py

Co-authored-by: Maximilian Sölch <maximiliansoelch@users.noreply.github.com>
coderabbitai[bot]
coderabbitai bot previously approved these changes May 25, 2024
Co-authored-by: Maximilian Sölch <maximiliansoelch@users.noreply.github.com>
undernagruzez and others added 4 commits May 25, 2024 03:21
…able.py

Co-authored-by: Maximilian Sölch <maximiliansoelch@users.noreply.github.com>
…able.py

Co-authored-by: Maximilian Sölch <maximiliansoelch@users.noreply.github.com>
…able.py

Co-authored-by: Maximilian Sölch <maximiliansoelch@users.noreply.github.com>
…able.py

Co-authored-by: Maximilian Sölch <maximiliansoelch@users.noreply.github.com>
coderabbitai[bot]
coderabbitai bot previously requested changes May 25, 2024
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Copy link
Contributor

@muradium muradium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reapproval

Copy link
Contributor

@coolchock coolchock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-approve

Copy link
Member

@maximiliansoelch maximiliansoelch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing my suggestions 👍

@maximiliansoelch maximiliansoelch added ready to merge maintainer-approved The feature maintainer has approved the PR and removed ready for review labels May 27, 2024
@maximiliansoelch maximiliansoelch added this to the 7.1.1 milestone May 27, 2024
@krusche krusche merged commit b34ffce into develop May 28, 2024
40 of 42 checks passed
@krusche krusche deleted the chore/use-github-for-test-coverage branch May 28, 2024 19:55
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore maintainer-approved The feature maintainer has approved the PR ready to merge too-long-open !!! This is an antipattern, we should aim for small PRs that are only open for a short time !!!
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

8 participants