-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development
: Use GitHub to build coverage tables
#8485
Conversation
Warning Rate Limit Exceeded@undernagruzez has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 21 minutes and 17 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe recent updates focus on transitioning the code coverage report generation and uploading processes from Bamboo to GitHub. The GitHub Actions workflow now includes steps to upload server and client test coverage reports. The supporting script for generating the coverage table has been refactored to interact with GitHub, requiring a GitHub token for authentication instead of Bamboo credentials. This involves changes in environment variable names, script arguments, and the addition of new functions to handle GitHub API interactions. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 5
supporting_scripts/generate_code_cov_table/generate_code_cov_table.py
Outdated
Show resolved
Hide resolved
supporting_scripts/generate_code_cov_table/generate_code_cov_table.py
Outdated
Show resolved
Hide resolved
…able.py Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
…able.py Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
Development
Use Github to build coverage tablesDevelopment
: Use Github to build coverage tables
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good and I ran it locally, though that is obviously an imperfect test, without any data. Do you have any PR that you could base on top of this, so we have a realistic example? Could also just be a test PR.
I left 2 small nitpick comments that you may want to implement.
supporting_scripts/generate_code_cov_table/generate_code_cov_table.py
Outdated
Show resolved
Hide resolved
Thanks for your review @Hialus. I have a currently open PR, but it has to be merged soon. I'll open another PR soon, whose review should take assumingly longer than this one, so unnecessary diff will be gone, I'll let you know. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, just two small comments.
supporting_scripts/generate_code_cov_table/generate_code_cov_table.py
Outdated
Show resolved
Hide resolved
supporting_scripts/generate_code_cov_table/generate_code_cov_table.py
Outdated
Show resolved
Hide resolved
…able.py Co-authored-by: Timor Morrien <timor.morrien@tum.de>
…able.py Co-authored-by: Maximilian Sölch <maximiliansoelch@users.noreply.github.com>
8092474
Co-authored-by: Maximilian Sölch <maximiliansoelch@users.noreply.github.com>
…able.py Co-authored-by: Maximilian Sölch <maximiliansoelch@users.noreply.github.com>
…able.py Co-authored-by: Maximilian Sölch <maximiliansoelch@users.noreply.github.com>
…able.py Co-authored-by: Maximilian Sölch <maximiliansoelch@users.noreply.github.com>
…able.py Co-authored-by: Maximilian Sölch <maximiliansoelch@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reapproval
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re-approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for implementing my suggestions 👍
Checklist
General
Motivation and Context
Bamboo is used as source for the coverage artifacts. Now, Github will upload the artifacts too and the script will use them.
Description
The 'Test' workflow has been adapted. 'generate_code_cov_table.py' has been adapted.
Steps for Testing
This PR is difficult to test as there are no code changes and therefore no test coverage. But, I didn't change the part related to generation of the coverage table. Follow the rules described in supporting_scripts/generate_code_cov_table/README.md and make sure no error is thrown. Important: this branch should be active.
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Code Review
Manual Tests