Development: Fix version table check for MySQL

[Hialus]

Checklist

General

• I tested all changes and their related features with all corresponding user types on a test server.
• This is a small issue that I tested locally and was confirmed by another developer on a test server.
• Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
• I chose a title conforming to the naming conventions for pull requests.

Server

• Important: I implemented the changes with a very good performance and prevented too many (unnecessary) database calls.
• I strictly followed the server coding and design guidelines.

Motivation and Context

During the setup of the Artemis instance at the TU Dortmund, we encountered an issue where the MySQL database could not be setup. There was not exception of any kind it just failed to start with the message that the version table does not exist.

Description

I firstly added the exception that happened to the log output.
Secondly the issue was that we execute statement.executeQuery("SELECT * FROM DATABASECHANGELOG;");, which on some MySQL setups leads to a message table databasechangelog doesn't exist, but on other MySQL setups leads to table DATABASECHANGELOG doesn't exist. To support both I replaced contains with StringUtils:: containsIgnoreCase.

This was already tested and works for the TU Dortmund.

Steps for Testing

Prerequisites:

• Only locally possible
• A completely fresh (bare-metal) MySQL database
• Start Artemis for this DB

Review Progress

Performance Review

• I (as a reviewer) confirm that the server changes (in particular related to database calls) are implemented with a very good performance

Code Review

• Code Review 1
• Code Review 2

Manual Tests

• Test 1
• Test 2

[coderabbitai]

Walkthrough

The recent update enhances error handling in DatabaseMigration.java by incorporating StringUtils.containsIgnoreCase from org.apache.commons.lang for more robust error message checking. The logging mechanism has also been improved to provide better debugging information by including the exception details.

Changes

File	Change Summary
.../artemis/config/migration/DatabaseMigration.java	Imported StringUtils from org.apache.commons.lang and updated error handling to use StringUtils.containsIgnoreCase. Enhanced log.error to include the exception e.

---

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between be094ac and 6636179.

Files selected for processing (1)

• src/main/java/de/tum/in/www1/artemis/config/migration/DatabaseMigration.java (2 hunks)

Files skipped from review as they are similar to previous changes (1)

• src/main/java/de/tum/in/www1/artemis/config/migration/DatabaseMigration.java

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1