Programming exercise: Fix an issue with VHDL not showing build failed correctly
#8945
Conversation
WalkthroughThis update primarily enhances the VHDL test environment by renaming and modifying functions in Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Script as default.sh
participant AssignmentDir as assignment Directory
participant Tests as tests Directory
User->>Script: Execute prepare_files()
Script->>AssignmentDir: Remove _tb.vhd files
Script->>Tests: Copy *_tb.vhd files to assignment/
Script->>AssignmentDir: Place copied *_tb.vhd files
User->>Makefile: Run all target
Makefile->>GHDL: Elaborate $(NAME)_tb
Makefile->>GHDL: Run $(NAME)_tb
sequenceDiagram
participant User
participant CompileTest as compileTest.py
participant GHDL
participant Result as Test Result
User->>CompileTest: Run export_junit()
CompileTest->>GHDL: Execute VHDL Testbench
GHDL->>CompileTest: Return stdout, stderr, retCode
alt retCode = 0
CompileTest->>Result: Add success info
else retCode != 0
CompileTest->>CompileTest: Return early
end
Tip AI model upgrade
|
github-actions
bot
added
server
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
krusche
changed the title
Programming exercise: Fix build failed not showProgramming exercise: Fix an issue with VHDL not showing build failed correctly
Checklist
General
Motivation and Context
Fix issue: #8886
Description
The problem is due to our VHDL template, not localci. The template generates a
result.xmleven though the code did not build, which makes artemis think that tests were run, so code was built. I adjusted the template so that it doesn't generate a test when build failsI changed the template we use so that it is more inline with the other programming languages. Now, we generateresult.xmlonly if the code compiles and the testbench was run. We generate the testcases using the python script using the output of the testbench.The new template should serve as a guide for instructors on how to generate test cases for vhdl exercises
This solution, however, introduces another small issue. When the instructor creates the exercise, the template result will not show the failed tests since it doesn't compile
Steps for Testing
Prerequisites:
After due date(default setting)verzoegerung.vhdis necessary)Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.
Review Progress
Code Review
Manual Tests
Summary by CodeRabbit
Bug Fixes
compileTest.pyscript to handle test failures more efficiently by returning early when errors occur.New Features
Improvements