-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adaptive learning
: Remove relates relation type for competencies
#8993
Adaptive learning
: Remove relates relation type for competencies
#8993
Conversation
Adaptive learning
: Remove Assumes RelationTypeAdaptive learning
: Remove assumes relation type for competencies
Adaptive learning
: Remove assumes relation type for competenciesAdaptive learning
: Remove relates relation type for competencies
WalkthroughThe update improves the management of competency relationships in course materials, enabling instructors to create and visualize relations such as "Assumes", "Extends", and "Matches". The "RELATES" type has been removed, and UI enhancements, including help icons and explanations for relation types, have been added. Additionally, translations were refined, and relevant test cases were adjusted to reflect these changes. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
...ebapp/app/course/competencies/competency-management/competency-relation-graph.component.html
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
...ebapp/app/course/competencies/competency-management/competency-relation-graph.component.html
Show resolved
Hide resolved
…-relates-relationship # Conflicts: # src/test/java/de/tum/in/www1/artemis/competency/CompetencyIntegrationTest.java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found some typos
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in Testing Session works as expected 🇹🇭
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally in testing session. LGTM 🇹🇭
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maintainer approved
🚨 🚨 Contains Database migration. Do not deploy to test servers 🚨 🚨
Checklist
General
Server
Client
Motivation and Context
The "Relates" relation between competencies is quite weak in what it expresses. Instead the other relation types should be used, so the learning paths can better understand the course structure and adequately suggest competencies and within them lecture units and exercises to the student.
Description
Removed the "Relates" relation between competencies and replaced all existing with "Assumes".
Additionally added tooltips to the relation selector, so other instructors better understand the intention of each relation.
Extended the documentation to include more details and explanations about the competency relations.
Steps for Testing
Prerequisites:
develop
relates
and anotherrelates
relation is now anassumes
relationTestserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.
Review Progress
Performance Review
Code Review
Manual Tests
Screenshots
New tooltip for relations:
![Bildschirmfoto 2024-07-11 um 12 47 44](https://private-user-images.githubusercontent.com/38322605/347788166-ac3b281e-8f11-41af-b3d6-5b8d460acb5d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjYwNzc5MzEsIm5iZiI6MTcyNjA3NzYzMSwicGF0aCI6Ii8zODMyMjYwNS8zNDc3ODgxNjYtYWMzYjI4MWUtOGYxMS00MWFmLWIzZDYtNWI4ZDQ2MGFjYjVkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MTElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTExVDE4MDAzMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTFkNmViZjdiY2RkMGRkMGZmMTE1ZWZhMzI5ZDgzZWUxOGUwYmNmNzA2ZDI4YjAxMWFiMjU3MzdlN2NkNmU5NzUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.oqX0sH50bAXuXWbQknrQbq3oDzwwKNTGbl1ZbFzvNJU)
Summary by CodeRabbit
New Features
Bug Fixes
RELATES
and added more descriptive types.Documentation
Localization
User Interface