Improved Deployment to make variables easier to change #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated dependencies updated kotlin version fixed a change in the API of Jetbrains
# Conflicts: # build.gradle.kts
Removed unnecessary comment
fixed some spelling/grammar stuff fixed project StartupActivity to use the new version ProjectActivity
fixed some style issues
# Conflicts: # build.gradle.kts # src/main/java/de/tum/www1/orion/settings/OrionSettingsProvider.java # src/main/java/de/tum/www1/orion/ui/settings/OrionPluginSettings.kt # src/main/resources/META-INF/plugin.xml
# Conflicts: # src/main/java/de/tum/www1/orion/settings/OrionSettingsProvider.java # src/main/resources/META-INF/plugin.xml
fixed and adapted pipeline
Kroko-fant
changed the title
lennart-keller
approved these changes
Sep 7, 2023
# Conflicts: # build.gradle.kts
Reverted newline
# Conflicts: # build.gradle.kts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Deployment changes in Orion are pretty complex as the plugin depends on external dependencies that often change versions.
To simplify these changes Orion now has all variables in a separate file so its easier to edit changes.
Description
Gradle uses a properties file where variables can be defined. with the new deployment changes the variables got moved out of the build file to properties.
Steps for Testing
Nothing in the plugin logic has changed. Changes were made in the plugins deployment therefor no manual testing is needed.
Review Progress
Code Review