Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Highlight Todos in Java Exercises #95

Merged
merged 11 commits into from
Nov 8, 2023
Merged

Feature Highlight Todos in Java Exercises #95

merged 11 commits into from
Nov 8, 2023

Conversation

Kroko-fant
Copy link
Contributor

@Kroko-fant Kroko-fant commented Oct 4, 2023 •
edited

Motivation and Context

Orion should be able to highlight todos in the template code even if the student deleted them.

Description

the assessment mode of Orion now provides the ability to view todos as comments inside of the assessment editor.

Steps for Testing

  1. Install Orion and start an exercise in assessment mode.
  2. Open a student file in the assessment editor and verify that the todos are mapped correctly.

Review Progress

Code Review

  • Review 1
  • Review 2

Manual Tests

  • Test 1
  • Test 2

Screenshots

Newly added Files by the student do not show any todos
grafik

Todos can stick to the File, Class and Method
grafik
grafik

@Kroko-fant Kroko-fant changed the title Feature/todos Feature Highlight Todos in Java Exercises Oct 17, 2023
@Kroko-fant Kroko-fant marked this pull request as ready for review October 17, 2023 12:31
jakubriegel
jakubriegel approved these changes Nov 7, 2023
View reviewed changes
Copy link

@jakubriegel jakubriegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Demonstrated on a ts. Works fine

jakubriegel
jakubriegel approved these changes Nov 7, 2023
View reviewed changes
Copy link

@jakubriegel jakubriegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Demonstrated on a ts. Works fine

MaximilianAnzinger
MaximilianAnzinger approved these changes Nov 7, 2023
View reviewed changes
Copy link

@MaximilianAnzinger MaximilianAnzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested during testing session, seems to work quite well 👍

@Kroko-fant Kroko-fant added feature New feature or request ready for review labels Nov 7, 2023
Jan-Thurner
Jan-Thurner approved these changes Nov 7, 2023
View reviewed changes
Copy link

@Jan-Thurner Jan-Thurner left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm during testing session.

@krusche krusche merged commit 8149738 into main Nov 8, 2023
3 of 4 checks passed
@krusche krusche deleted the feature/todos branch November 8, 2023 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubriegel jakubriegel jakubriegel approved these changes

@MaximilianAnzinger MaximilianAnzinger MaximilianAnzinger approved these changes

@Jan-Thurner Jan-Thurner Jan-Thurner approved these changes

Assignees
No one assigned
Labels
feature New feature or request ready for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Kroko-fant @jakubriegel @MaximilianAnzinger @Jan-Thurner @krusche