Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Wrong icons shown when using Nerd Font v3 #845

Closed
1 task done
pro-sumer opened this issue May 21, 2023 · 7 comments
Closed
1 task done

[Bug]: Wrong icons shown when using Nerd Font v3 #845

pro-sumer opened this issue May 21, 2023 · 7 comments
Assignees

Comments

@pro-sumer
Copy link

pro-sumer commented May 21, 2023

Version

  • latest

version

lsd 0.23.1

What OS are you seeing the problem on?

macOS

installation

Homebrew: brew install lsd

term

xterm-256color

ls-colors

no=00;38;5;244:di=37:ln=34:so=1;30:pi=1;30:ex=32:bd=1;30:cd=1;30:su=32:sg=32:tw=33:ow=33

What happened?

➜ lsd
�  01.mp3
�  02.mp3
�  03.mp3
蘿  playlist.m3u

What expected?

Proper icons for MP3 audio files and M3U playlists.

What else?

Nerd Fonts v3 is a major release that introduces some breaking changes.

@cacack
Copy link

cacack commented Jun 26, 2023

I had the same problem, kitty on Mac, but turned out I still had a v2.x version of nerdfont symbols installed.. Updated to latest (v3.0.2) and I'm back in business.

@cacack
Copy link

cacack commented Jun 27, 2023

Well I thought I had it fixed but after a restart of my terminal it came back...

@zwpaper
Copy link
Member

zwpaper commented Jul 4, 2023

hi we have updated the obsolete icons here #830, and I also check the code of mp3 is f001 https://github.com/lsd-rs/lsd/blob/master/src/theme/icon.rs#L488, and it is correct on nerd fonts cheat-sheet https://www.nerdfonts.com/cheat-sheet.

maybe you should check the font you using, or wait until the next release of lsd

/close

@muniu-bot muniu-bot bot closed this as completed Jul 4, 2023
@muniu-bot
Copy link

muniu-bot bot commented Jul 4, 2023

@zwpaper: Closing this issue.

In response to this:

hi we have updated the obsolete icons here #830, and I also check the code of mp3 is f001 https://github.com/lsd-rs/lsd/blob/master/src/theme/icon.rs#L488, and it is correct on nerd fonts cheat-sheet https://www.nerdfonts.com/cheat-sheet.

maybe you should check the font you using, or wait until the next release of lsd

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pro-sumer
Copy link
Author

pro-sumer commented Jul 4, 2023

I'm using the JetBrains Mono Nerd Font.

The F001 character looks fine in the Font Book:
Font Book

However, the last lsd (macOS) build from today still shows it wrong:

󰐑  test.m3u
�  test.mp3

@zwpaper Any suggestions on what to check?

@zwpaper
Copy link
Member

zwpaper commented Jul 5, 2023

@pro-sumer maybe check you terminal emulator and fonts setting?

As you can see in the code, we already set it to F001

@pro-sumer
Copy link
Author

Sorry, you're right.

Tried Warp instead of iTerm 2 and the correct characters are displayed (using the same font).

Also when using iTerm 2 Build 3.5.20230621-nightly instead of the latest (stable) Build 3.4.19 the correct characters are displayed, so this is an issue with the latest stable iTerm 2 build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants