Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix obsolete Nerd Font icons #830

Merged
merged 3 commits into from Apr 22, 2023
Merged

Fix obsolete Nerd Font icons #830

merged 3 commits into from Apr 22, 2023

Conversation

nix6839
Copy link
Contributor

@nix6839 nix6839 commented Mar 29, 2023

Replace the old code point with the new code point.
See: https://github.com/ryanoasis/nerd-fonts/releases/tag/v2.3.3

Material Design Icons
The Material Design Icons have to move codepoints. Historically we patch them in between F500 - FD46; but part of that range is needed for Chinese and other glyphs. With ryanoasis/nerd-fonts#773 and Plan 5+ of ryanoasis/nerd-fonts#365 their new home will be after F0001. And they grow considerably.

The v2.3.x release has both, the 'old' and the 'new' codepoints to enable you an easier transision. Please change already now your prompts and other uses to the new codepoints. Release v3.0.0 will finally drop the old codepoints (F500 - FD46).


TODO

  • Use cargo fmt
  • Add necessary tests
  • Add changelog entry
  • Update default config/theme in README (if applicable)

@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2023

Codecov Report

Merging #830 (2445d0c) into master (8c62e9e) will not change coverage.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##           master     #830   +/-   ##
=======================================
  Coverage   87.35%   87.35%           
=======================================
  Files          45       45           
  Lines        4280     4280           
=======================================
  Hits         3739     3739           
  Misses        541      541           
Impacted Files Coverage Δ
src/meta/name.rs 90.41% <100.00%> (ø)
src/theme/icon.rs 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@zwpaper zwpaper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you help to add some notice under FAQ about this change?

@nix6839
Copy link
Contributor Author

nix6839 commented Mar 30, 2023

can you help to add some notice under FAQ about this change?

Where is the FAQ? Should I add it to the README section?

(edited)
Oh sorry I found that.

@nix6839 nix6839 requested review from zwpaper and removed request for Peltoche and meain March 30, 2023 03:37
@nix6839
Copy link
Contributor Author

nix6839 commented Mar 30, 2023

@zwpaper I've added a FAQ. I'm not a native English speaker so please let me know if you see anything strange in the FAQs.

@zwpaper
Copy link
Member

zwpaper commented Mar 30, 2023

hi @nix6839, I have one more question, Are the pre-patched fonts updated to this latest v2.3.x version? https://github.com/ryanoasis/nerd-fonts#patched-fonts

looks like the Hack Nerd I was using did not show the expected icons

@nix6839
Copy link
Contributor Author

nix6839 commented Mar 30, 2023

@zwpaper If you look at https://washnix.com/hack-nerd/, it is patched correctly.

image

The source code of the page: https://github.com/nix6839/hack-nerd/blob/main/index.html

@zwpaper zwpaper mentioned this pull request Apr 22, 2023
6 tasks
@zwpaper
Copy link
Member

zwpaper commented Apr 22, 2023

hi @nix6839, I double check for the icons, it works like a charm, will merge after CI passed, thanks again!

@nix6839
Copy link
Contributor Author

nix6839 commented Apr 22, 2023

Thank you for your hard work.

@zwpaper zwpaper merged commit 5ecb868 into lsd-rs:master Apr 22, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants