Add console option to select icon theme #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 14, 2019 19:47
It's just an icon set with empty icon maps, so everything should fall through to the default folder/file icons.
Possible values are `default` and `unicode`.
Peltoche
requested changes
Jan 15, 2019
There was a problem hiding this comment.
Hello @loewenheim ,
Thanks for the PR! I think the unicode icons don't show up because if you set --theme=unicode you return and empty HashMap for the Icons.icons_by_name and Icons.icons_by_extension.
Peltoche
requested changes
Jan 16, 2019
added 3 commits
January 16, 2019 16:53
|
I don’t know why this CI task fails. |
Peltoche
reviewed
Jan 18, 2019
I don't know why but sometime a simple restart do the trick. This should be a travis bug I guess... |
Peltoche
approved these changes
Jan 19, 2019
|
All good! Merged! Thanks for the contribution. :) |
|
My pleasure :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I’ve added a console option called
themeto select an icon set. The possible values aredefaultfor the current behavior andunicodeto use only the default unicode icons. Unfortunately, the unicode icons don’t show up correctly on my machine, so I can’t really verify.This fixes #40.