support AllReduce with customised tree #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fertakis Could you review this PR? Check the naming of the functions because this will later become part of the public APIs. |
kfertakis
approved these changes
May 6, 2020
Comment on lines
27
to
29
| def monitored_all_reduce(t, tree, op='sum'): | ||
| """Create a new all_reduce operator for given tensor and topology.""" | ||
| return _op_lib.kungfu_monitored_all_reduce(t, tree, op=op) |
There was a problem hiding this comment.
Should we provide a further description regarding the structure and usage of the tree parameter?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.