Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] LTP test is not reported failed if binary is not built successfully #810

Closed
hukoyu opened this issue Aug 20, 2020 · 2 comments
Closed
Assignees
Labels
p3 Non-blocking priority

Comments

@hukoyu
Copy link
Collaborator

hukoyu commented Aug 20, 2020

As can be seen from PR lsds/ltp#74
Some LTP tests were having build errors and binaries were not created, and test was enabled in sgx-lkl.

but ltp test runner script looks like cannot report test failed if test binary is missing. The test is not reported at all so it is not easy to catch such failures and one can assume test passed if there is no any failure.

Fix it an report that test binary is not available as failure in CI pipeline

@hukoyu hukoyu self-assigned this Aug 20, 2020
@hukoyu hukoyu added needs-triage Bug does not yet have a priority assigned p1 Medium priority labels Aug 20, 2020
@hukoyu hukoyu added p3 Non-blocking priority and removed needs-triage Bug does not yet have a priority assigned p1 Medium priority labels Aug 21, 2020
@hukoyu
Copy link
Collaborator Author

hukoyu commented Aug 21, 2020

I investigated this and if the test binary is not available, actually non-zero exit code is returned and test failed. It must be something else. I will have an eye on this issue. For now there is nothing to do. Lowering priority to p3.

@hukoyu
Copy link
Collaborator Author

hukoyu commented Aug 21, 2020

Closing this issue and will reopen if I see a repeatable case.

@hukoyu hukoyu closed this as completed Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3 Non-blocking priority
Projects
None yet
Development

No branches or pull requests

1 participant