Fixing 6 LTP test build errors #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hukoyu
requested review from
KenGordon,
SeanTAllen,
davidchisnall,
prp,
paulcallen and
vtikoo
This was referenced Aug 20, 2020
KenGordon
reviewed
Aug 20, 2020
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was investigating ltp build errors and found build errors for these 6 tests and fixed.
Also verified that connect01, fstat03, write05, chroot03 are enabled tests but they are not reported failed evenif their binaries failed to build. They are not reported at all. So there is a bug in ltp test runner script that if ltp test binary is not available (not built successfully) , it is not reported as failure. I will investigate and submit a PR to fix that to lsds/sgx-lkl.
After we merge this PR and bump ltp submodule in sgx-lkl, these 4 tests will be reported pass.
cc @SeanTAllen @KenGordon @paulcallen @bodzhang @davidchisnall