Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testsuite now fails with rspec-mocks >= 3.10.3 #1432

Closed
mtasaka opened this issue Feb 12, 2022 · 0 comments · Fixed by #1433
Closed

Testsuite now fails with rspec-mocks >= 3.10.3 #1432

mtasaka opened this issue Feb 12, 2022 · 0 comments · Fixed by #1433

Comments

@mtasaka
Copy link
Contributor

mtasaka commented Feb 12, 2022

With git head ( 7f399d3 ), test suite now fails with rspec-mocks 3.10.3 (or rspec suite 3.11.0) as:

Failures:

  1) YARD::CodeObjects::Base#format sends object to Templates.render
     Failure/Error: Templates::Engine.render(options)

       YARD::Templates::Engine received :render with unexpected arguments
         expected: ({:object=>#<yardoc method #method>, :type=>:method, :x=>1})
              got: ({:object=>#<yardoc method #method>, :type=>:method, :x=>1})
     # ./lib/yard/code_objects/base.rb:504:in `format'
     # ./spec/code_objects/base_spec.rb:253:in `block (3 levels) in <top (required)>'
     # ./spec/spec_helper.rb:127:in `block (2 levels) in <top (required)>'

  2) YARD::Templates::Helpers::BaseHelper#linkify passes off to #link_url if argument is recognized as a URL
     Failure/Error: link_url(args[0], args[1], {:target => '_parent'}.merge(args[2] || {}))

       #<RSpec::ExampleGroups::YARDTemplatesHelpersBaseHelper::Linkify "passes off to #link_url if argument is recognized as a URL" (./spec/templates/helpers/base_helper_spec.rb:98)> received :link_url with unexpected arguments
         expected: ("http://yardoc.org/", nil, {:target=>"_parent"})
              got: ("http://yardoc.org/", nil, {:target=>"_parent"})
     # ./lib/yard/templates/helpers/base_helper.rb:59:in `linkify'
     # ./spec/templates/helpers/base_helper_spec.rb:101:in `block (3 levels) in <top (required)>'
     # ./spec/spec_helper.rb:127:in `block (2 levels) in <top (required)>'

  3) YARD::Templates::Template#run renders all sections with options
     Failure/Error: "Template(#{self.class.path}) [section=#{section.name}]"

     NoMethodError:
       undefined method `name' for nil:NilClass

               "Template(#{self.class.path}) [section=#{section.name}]"
                                                               ^^^^^
     # ./lib/yard/templates/template.rb:343:in `inspect'
     # ./lib/yard/templates/template.rb:257:in `run'
     # ./spec/templates/template_spec.rb:213:in `block (3 levels) in <top (required)>'
     # ./spec/spec_helper.rb:127:in `block (2 levels) in <top (required)>'

Finished in 6.71 seconds (files took 0.83294 seconds to load)
1938 examples, 3 failures, 8 pending

Failed examples:

rspec ./spec/code_objects/base_spec.rb:250 # YARD::CodeObjects::Base#format sends object to Templates.render
rspec ./spec/templates/helpers/base_helper_spec.rb:98 # YARD::Templates::Helpers::BaseHelper#linkify passes off to #link_url if argument is recognized as a URL
rspec ./spec/templates/template_spec.rb:208 # YARD::Templates::Template#run renders all sections with options
mtasaka added a commit to mtasaka/yard that referenced this issue Feb 12, 2022
rspec-mocks 3.10.3 changed "with" syntax behavior to support
ruby 3 keyword arguments separation:

rspec/rspec-mocks#1394
rspec/rspec-mocks#1460

Fix yard testsuite accordingly.

Fixes lsegal#1432
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant