Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle rspec-mocks 3.10.3 change with "with" syntax #1433

Merged
merged 1 commit into from Jun 1, 2022

Conversation

mtasaka
Copy link
Contributor

@mtasaka mtasaka commented Feb 12, 2022

rspec-mocks 3.10.3 changed "with" syntax behavior to support
ruby 3 keyword arguments separation:

rspec/rspec-mocks#1394
rspec/rspec-mocks#1460

Fix yard testsuite accordingly.

Fixes #1432

Description

Describe your pull request and problem statement here.

Completed Tasks

  • [ x] I have read the Contributing Guide.
  • [ x] The pull request is complete (implemented / written).
  • [ x] Git commits have been cleaned up (squash WIP / revert commits).
  • [ x] I wrote tests and ran bundle exec rake locally (if code is attached to PR).

rspec-mocks 3.10.3 changed "with" syntax behavior to support
ruby 3 keyword arguments separation:

rspec/rspec-mocks#1394
rspec/rspec-mocks#1460

Fix yard testsuite accordingly.

Fixes lsegal#1432
@lsegal lsegal merged commit e1e378c into lsegal:main Jun 1, 2022
@lsegal lsegal mentioned this pull request Jun 1, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants