You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
It looks like some mashtree parameters such as --kmerlength and --sketch-size are not propagated to mash sketch when running the bootstrap replicates.
To Reproduce
Steps to reproduce the behavior:
I suspected there was an issue when I got an error when running mashtree_bootstrap.pl. The error itself was my fault and resolved, but I noticed messages like this in the error log:
This message was unexpected because I had specified --kmerlength 22 --sketch-size 1000000. I confirmed from the log that these parameters looked fine for the initial mashtree run:
I experienced this too, but as described in Issue #63 this behaviour is fixed by putting --kmerlength and other parameters relevant to the sketch after -- double dashes. Something like:
Describe the bug
It looks like some
mashtree
parameters such as--kmerlength
and--sketch-size
are not propagated tomash sketch
when running the bootstrap replicates.To Reproduce
Steps to reproduce the behavior:
I suspected there was an issue when I got an error when running
mashtree_bootstrap.pl
. The error itself was my fault and resolved, but I noticed messages like this in the error log:This message was unexpected because I had specified
--kmerlength 22 --sketch-size 1000000
. I confirmed from the log that these parameters looked fine for the initialmashtree
run:Expected behavior
I would expect the
mashtree
runs with the different seeds for bootstrapping would use the same parametersAdditional context
I may be misunderstanding the code or log files, but I think the issue could be due to this snippet of code:
https://github.com/lskatz/mashtree/blob/master/bin/mashtree_bootstrap.pl#L160-L172
The parameter
$mashtreeOptions
doesn't appear to be used?Thank you very much for making this great software!
The text was updated successfully, but these errors were encountered: