-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patches selection for installation #3
Conversation
Looks much better! |
bfe2418
to
f1560f0
Compare
* It adds support to expand and collapse to see the patch details. * The list can receive a method that it is called when clicking the 'Install Patches' button.
f1560f0
to
272987f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost LGTM 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 👍
Guys, I'm a bit late here but looking at the animation included in the PR description I think we could improve the Even we could evaluate if it worth it displaying a small summary before proceed. Maybe I'd like to have the opportunity to see what I selected among hundred of patches before going ahead. Although it could be a little be annoying. Just my quick thoughts :) |
@dgdavid sure, there are lots of improvements possible, we just started 😉 We could allow sorting the table, than you could sort (group by) by the selection status. It would be also nice to have some filtering (important/security/optional patches), search, etc... |
@dgdavid @lslezak Thanks! Yes, there are several improvements we could do (and some performance issues to fix). But we just want to have something visible to start. Now we will move to the 'snapshots' list. And, later, we can refine both of them. It will be worthwhile to collect a list of things to improve (confluence, issues, wiki...). |
This PR extends the existing patches list with support for selecting patches for installation. Once the user selects some package, it is possible to click the
Install Patches
button which runs a custom function (the real function is not ready yet). If no patch is selected, the button remains disabled.Apart from selecting/unselecting patches, the user can expand/collapse each patch to find out additional details.
And if no patches are pending for installation, the user gets a nice notice about it.
To do
Improve the packages description avoiding the dirty trick of using(let's keep it by now).<pre>
to keep the newlines :)