Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patches selection for installation #3

Merged
merged 6 commits into from
Nov 13, 2020

Conversation

imobachgs
Copy link
Contributor

@imobachgs imobachgs commented Nov 10, 2020

This PR extends the existing patches list with support for selecting patches for installation. Once the user selects some package, it is possible to click the Install Patches button which runs a custom function (the real function is not ready yet). If no patch is selected, the button remains disabled.

patches-list

Apart from selecting/unselecting patches, the user can expand/collapse each patch to find out additional details.

And if no patches are pending for installation, the user gets a nice notice about it.

system-updated

To do

  • Improve the packages description avoiding the dirty trick of using <pre> to keep the newlines :) (let's keep it by now).
  • Fix the titles and, probably, the layout of the whole page.
  • Connect with the real function to perform the update (future).
  • Improve the feedback while the list of patches is being retrieved.

@lslezak
Copy link
Owner

lslezak commented Nov 10, 2020

Looks much better!

@imobachgs imobachgs force-pushed the extend-patches-list branch 3 times, most recently from bfe2418 to f1560f0 Compare November 13, 2020 07:02
* It adds support to expand and collapse to see the patch details.
* The list can receive a method that it is called when clicking the
  'Install Patches' button.
@imobachgs imobachgs changed the title [WIP] Patches selection for installation Patches selection for installation Nov 13, 2020
@imobachgs imobachgs marked this pull request as ready for review November 13, 2020 10:21
Copy link
Owner

@lslezak lslezak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost LGTM 😉

src/components/UpdatedSystemNotice.js Outdated Show resolved Hide resolved
Copy link
Owner

@lslezak lslezak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@lslezak lslezak merged commit 94cd6dd into lslezak:master Nov 13, 2020
@dgdavid
Copy link

dgdavid commented Nov 13, 2020

Guys, I'm a bit late here but looking at the animation included in the PR description I think we could improve the Install Patches button by adding a counter. I mean, Install all patches, Install 6 selected patches, etc

Even we could evaluate if it worth it displaying a small summary before proceed. Maybe I'd like to have the opportunity to see what I selected among hundred of patches before going ahead. Although it could be a little be annoying.

Just my quick thoughts :)

@imobachgs imobachgs deleted the extend-patches-list branch November 13, 2020 11:26
@lslezak
Copy link
Owner

lslezak commented Nov 13, 2020

@dgdavid sure, there are lots of improvements possible, we just started 😉

We could allow sorting the table, than you could sort (group by) by the selection status.

It would be also nice to have some filtering (important/security/optional patches), search, etc...

@imobachgs
Copy link
Contributor Author

imobachgs commented Nov 13, 2020

@dgdavid @lslezak Thanks! Yes, there are several improvements we could do (and some performance issues to fix). But we just want to have something visible to start. Now we will move to the 'snapshots' list. And, later, we can refine both of them.

It will be worthwhile to collect a list of things to improve (confluence, issues, wiki...).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants