-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[linux] Allow reproducible builds #94
Conversation
Thanks for working on this! Note that for reproducible builds we need to avoid embedding the time zone also, so that date call (for the SOURCE_DATE_EPOCH case) should also use See also "reading the variable": https://reproducible-builds.org/docs/source-date-epoch/ |
@eli-schwartz Thanks for noticing. I just pushed an amended commit with the fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you update 00DIST file?
@ lrosenman, I will merge this though testing on freebsd is failed because the change is nothing to do with other dialect than Linux. |
@masatake the FreeBSD CI is failed due to the Cirrus stuff using outdated images. |
@lrosenman, thank you. |
@masatake Is there a procedure to updating the 00DIST file? Or do I just edit it by hand? |
@T4cC0re, please, edit the file by hand directly. |
@masatake There is a Footnote in the bootom of the file with your name and a date. Should I change the date or leave it be? |
Please, keep my name as is. Please, write what you did as an item like:
The number of pull request (#94) and your name should be written in the item. Updating 00CREDITS is ... my job. |
@masatake I updated the 00DIST file, does that look good to you? |
@T4cC0re, yes thank you. I will merge this, and we will make a release in ... a month. |
The FreeBSD CI images are changed in master now, but until #97 is merged they will fail. This should be fine to merge. |
@lrosenman, though you merged #97, the tests of this pull request are failed. |
Yes, until I can get the kernel folks to look at the code and fix getting the executable and library names. |
@lrosenman, I see. Thank you. |
In a reproducible build all varied information is removed. This patch does so, by checking if the standard [SOURCE_DATE_EPOCH](https://reproducible-builds.org/specs/source-date-epoch/) variable is set. If it is, we are attempting a reproducible build and will strip varying information.
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
@T4cC0re, thank you. |
In openSUSE, we had |
lsof-org#94 (comment) lrosenman commented on Jun 5 @masatake the FreeBSD CI is failed due to the Cirrus stuff using outdated images. I'll see if I can figure out how to fix that for all 3 FreeBSD versions. Till we find the way to update the images, disable the testing. Signed-off-by: Masatake YAMATO <yamato@redhat.com>
#94 (comment) lrosenman commented on Jun 5 @masatake the FreeBSD CI is failed due to the Cirrus stuff using outdated images. I'll see if I can figure out how to fix that for all 3 FreeBSD versions. Till we find the way to update the images, disable the testing. Signed-off-by: Masatake YAMATO <yamato@redhat.com>
In a reproducible build all varied information is removed.
This patch does so, by checking if the standard SOURCE_DATE_EPOCH variable is set.
If it is, we are attempting a reproducible build and will strip varying information.