Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bit vector read on older GHCs #100

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Fix bit vector read on older GHCs #100

merged 1 commit into from
Jul 20, 2023

Conversation

lsrcz
Copy link
Owner

@lsrcz lsrcz commented Jul 19, 2023

The pull request fixed the bug introduced in #99 where the code does not build on GHC 8.10.7.

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Patch coverage: 70.58% and project coverage change: +0.31 🎉

Comparison is base (cba5d95) 31.38% compared to head (1489d75) 31.70%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #100      +/-   ##
==========================================
+ Coverage   31.38%   31.70%   +0.31%     
==========================================
  Files          49       49              
  Lines        5231     5246      +15     
  Branches      269      276       +7     
==========================================
+ Hits         1642     1663      +21     
+ Misses       3320     3307      -13     
- Partials      269      276       +7     
Impacted Files Coverage Δ
src/Grisette/Core/Data/BV.hs 38.08% <70.58%> (+4.91%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lsrcz lsrcz merged commit e870bc1 into main Jul 20, 2023
36 checks passed
@lsrcz lsrcz deleted the fix-read-bv branch July 20, 2023 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant