Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the Union constructors and patterns #133

Merged
merged 1 commit into from Oct 1, 2023
Merged

Conversation

lsrcz
Copy link
Owner

@lsrcz lsrcz commented Oct 1, 2023

This is a breaking change.

  • If and Single are now UnionIf and UnionSingle.
  • IfU and SingleU are now If and Single.
  • The If and Single, when used as constructors, now merges the result.

@lsrcz lsrcz changed the title 💥 Rename the Union constructors and patterns Rename the Union constructors and patterns Oct 1, 2023
This is a breaking change. If and Single are now UnionIf and UnionSingle. IfU and SingleU are now If and Single. The If and Single, when used as constructors, now merges the result.
@codecov
Copy link

codecov bot commented Oct 1, 2023

Codecov Report

Attention: 35 lines in your changes are missing coverage. Please review.

Files Coverage Δ
src/Grisette/Core/Data/Class/SimpleMergeable.hs 63.92% <33.33%> (ø)
src/Grisette/Core/Control/Monad/UnionM.hs 69.44% <75.00%> (+0.14%) ⬆️
src/Grisette/Core/Data/Union.hs 51.56% <53.33%> (-4.92%) ⬇️

... and 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@lsrcz lsrcz merged commit ebad25a into main Oct 1, 2023
35 of 36 checks passed
@lsrcz lsrcz deleted the rename-union-constructors branch October 1, 2023 13:48
@lsrcz
Copy link
Owner Author

lsrcz commented Oct 4, 2023

Fixes #110.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant