Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed the symbolic identifier type to Text #141

Merged
merged 1 commit into from Oct 5, 2023
Merged

Changed the symbolic identifier type to Text #141

merged 1 commit into from Oct 5, 2023

Conversation

lsrcz
Copy link
Owner

@lsrcz lsrcz commented Oct 5, 2023

This pull request changed the symbolic identifier type from String to Text. Resolves #115.

@lsrcz lsrcz self-assigned this Oct 5, 2023
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Files Coverage Δ
src/Grisette/Backend/SBV/Data/SMT/Lowering.hs 40.18% <ø> (ø)
src/Grisette/Core/Data/Class/Solvable.hs 50.00% <ø> (ø)
...IR/SymPrim/Data/Prim/InternedTerm/InternedCtors.hs 90.56% <ø> (ø)
src/Grisette/IR/SymPrim/Data/SymPrim.hs 24.39% <ø> (+0.24%) ⬆️
src/Grisette/Core/Data/Class/GenSym.hs 54.94% <33.33%> (ø)
...Grisette/IR/SymPrim/Data/Prim/InternedTerm/Term.hs 51.37% <60.00%> (ø)

... and 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@lsrcz lsrcz merged commit 095e272 into main Oct 5, 2023
35 of 36 checks passed
@lsrcz lsrcz deleted the change-ident-to-text branch February 17, 2024 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lsrcz lsrcz

Labels
breaking change (PVP major)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use Text for the symbolic constant identifiers
1 participant
@lsrcz