Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed BVSignConversion to SignConversion, add instances to it. #142

Merged
merged 1 commit into from Oct 20, 2023

Conversation

lsrcz
Copy link
Owner

@lsrcz lsrcz commented Oct 5, 2023

This pull request renamed the BVSignConversion type to SignConversion type and added instances for Data.Word and Data.Int types. Resolves #111.

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Attention: 44 lines in your changes are missing coverage. Please review.

Files Coverage Δ
src/Grisette/Core/Data/BV.hs 38.55% <ø> (ø)
src/Grisette/Core/Data/Class/BitVector.hs 0.00% <ø> (ø)
...IR/SymPrim/Data/Prim/InternedTerm/InternedCtors.hs 90.56% <100.00%> (ø)
...SymPrim/Data/Prim/InternedTerm/TermSubstitution.hs 30.00% <0.00%> (ø)
src/Grisette/IR/SymPrim/Data/Prim/Model.hs 51.21% <0.00%> (ø)
src/Grisette/IR/SymPrim/Data/SymPrim.hs 24.14% <0.00%> (ø)
src/Grisette/Backend/SBV/Data/SMT/Lowering.hs 40.18% <0.00%> (ø)
...Grisette/IR/SymPrim/Data/Prim/InternedTerm/Term.hs 51.37% <50.00%> (ø)
...rc/Grisette/IR/SymPrim/Data/Prim/PartialEval/BV.hs 26.31% <0.00%> (ø)
src/Grisette/Core/Data/Class/SignConversion.hs 0.00% <0.00%> (ø)
... and 1 more

... and 2 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@lsrcz lsrcz merged commit 409d71e into main Oct 20, 2023
34 of 36 checks passed
@lsrcz lsrcz deleted the signed-conversion branch October 20, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BVSignConversion type class should be available to Data.Word and Data.Int data types.
1 participant