Huge refactoring to make module structures clearer #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsrcz
force-pushed
the
refactor-cyclic-dependency
branch
from
48af999
to
eac812d
Compare
Codecov ReportAttention:
... and 3 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
lsrcz
force-pushed
the
refactor-cyclic-dependency
branch
from
22621aa
to
dd802c2
Compare
…tives to the file defining the classes
… reduce cyclic dependency
lsrcz
force-pushed
the
refactor-cyclic-dependency
branch
from
8856610
to
5b23957
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request will be a huge refactoring to make module structures clearer and try to remove most hs-boot files and SOURCE imports.
We removed the
SymBoolOpandSymIntegerOp. These type classes and constraints are obsolete, not used, and will cause more cyclic dependencies. We also moved some instances for symbolic primitives andUnionM. This reduces the number of .hs-boot files needed.