Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shift by symbolic #151

Merged
merged 10 commits into from
Nov 8, 2023
Merged

Shift by symbolic #151

merged 10 commits into from
Nov 8, 2023

Conversation

lsrcz
Copy link
Owner

@lsrcz lsrcz commented Oct 27, 2023

This pull request adds support for symbolic shifting and rotation where the shifting or rotation amount is symbolic. Resolves #107.

@lsrcz lsrcz force-pushed the shift-by-symbolic branch 3 times, most recently from f6f9b4e to 2155556 Compare October 27, 2023 09:00
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Attention: 98 lines in your changes are missing coverage. Please review.

Files Coverage Δ
src/Grisette/Core/Data/BV.hs 38.40% <100.00%> (+0.56%) ⬆️
...IR/SymPrim/Data/Prim/InternedTerm/InternedCtors.hs 90.90% <100.00%> (+0.34%) ⬆️
src/Grisette/Backend/SBV/Data/SMT/Lowering.hs 42.81% <87.50%> (+2.16%) ⬆️
...SymPrim/Data/Prim/InternedTerm/TermSubstitution.hs 28.84% <0.00%> (-1.16%) ⬇️
src/Grisette/IR/SymPrim/Data/Prim/Model.hs 50.97% <0.00%> (-0.50%) ⬇️
src/Grisette/IR/SymPrim/Data/SymPrim.hs 27.75% <84.61%> (+10.76%) ⬆️
...Grisette/IR/SymPrim/Data/Prim/InternedTerm/Term.hs 51.81% <66.66%> (+0.44%) ⬆️
src/Grisette/Core/Data/Class/SafeSymRotate.hs 76.31% <76.31%> (ø)
src/Grisette/Core/Data/Class/SymRotate.hs 59.09% <59.09%> (ø)
.../Grisette/IR/SymPrim/Data/Prim/PartialEval/Bits.hs 84.61% <79.06%> (-2.89%) ⬇️
... and 3 more

... and 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!

@lsrcz lsrcz force-pushed the shift-by-symbolic branch 2 times, most recently from 98b3997 to 6867c10 Compare November 8, 2023 09:32
@lsrcz lsrcz merged commit 034c3e8 into main Nov 8, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow symbolic bit vectors to be shifted by a symbolic bit vector value of the same bit size
1 participant