Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize mergeable typeclass #170

Merged
merged 8 commits into from
Feb 17, 2024
Merged

Reorganize mergeable typeclass #170

merged 8 commits into from
Feb 17, 2024

Conversation

lsrcz
Copy link
Owner

@lsrcz lsrcz commented Feb 17, 2024

This pull request reorganized the whole stack for the Mergeable containers. The new TryMerge type class now does not require the container to actually perform the merging.

@lsrcz lsrcz force-pushed the reorganize-mergeable-typeclass branch from 49c164c to a497924 Compare February 17, 2024 03:26
Copy link

codecov bot commented Feb 17, 2024

Codecov Report

Attention: 138 lines in your changes are missing coverage. Please review.

Comparison is base (0e70db6) 53.28% compared to head (a497924) 52.87%.

Files Patch % Lines
src/Grisette/Core/Data/Class/TryMerge.hs 23.63% 42 Missing ⚠️
src/Grisette/Core/Control/Monad/UnionM.hs 67.27% 16 Missing and 2 partials ⚠️
src/Grisette/Core/Data/Class/SafeDivision.hs 0.00% 18 Missing ⚠️
src/Grisette/Core/Data/Class/SOrd.hs 53.33% 14 Missing ⚠️
src/Grisette/Core/Data/Class/PlainUnion.hs 38.09% 13 Missing ⚠️
src/Grisette/Core/Data/Class/SafeLinearArith.hs 45.83% 12 Missing and 1 partial ⚠️
src/Grisette/Core/Data/Union.hs 33.33% 8 Missing ⚠️
src/Grisette/Core/Data/Class/GenSym.hs 77.77% 4 Missing and 2 partials ⚠️
src/Grisette/Lib/Control/Monad.hs 57.14% 2 Missing and 1 partial ⚠️
src/Grisette/Core/Data/Class/SimpleMergeable.hs 94.11% 2 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #170      +/-   ##
==========================================
- Coverage   53.28%   52.87%   -0.42%     
==========================================
  Files          66       68       +2     
  Lines        5848     5852       +4     
  Branches      455      453       -2     
==========================================
- Hits         3116     3094      -22     
- Misses       2277     2305      +28     
+ Partials      455      453       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lsrcz lsrcz merged commit 6695567 into main Feb 17, 2024
19 of 20 checks passed
@lsrcz lsrcz deleted the reorganize-mergeable-typeclass branch February 17, 2024 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant