Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine safe operations #172

Merged
merged 9 commits into from
Feb 18, 2024
Merged

Refine safe operations #172

merged 9 commits into from
Feb 18, 2024

Conversation

lsrcz
Copy link
Owner

@lsrcz lsrcz commented Feb 18, 2024

This pull request refines the interfaces to safe operations after TryMerge is available.

Copy link

codecov bot commented Feb 18, 2024

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (f9271d6) 52.95% compared to head (794367d) 54.56%.

❗ Current head 794367d differs from pull request most recent head 2df8384. Consider uploading reports for the commit 2df8384 to get more accurate results

Files Patch % Lines
src/Grisette/Core/Data/Class/SafeDivision.hs 68.75% 8 Missing and 2 partials ⚠️
src/Grisette/Core/Data/Class/SafeLinearArith.hs 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #172      +/-   ##
==========================================
+ Coverage   52.95%   54.56%   +1.60%     
==========================================
  Files          69       69              
  Lines        5865     5786      -79     
  Branches      454      432      -22     
==========================================
+ Hits         3106     3157      +51     
+ Misses       2305     2197     -108     
+ Partials      454      432      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lsrcz lsrcz merged commit 638c809 into main Feb 18, 2024
11 checks passed
@lsrcz lsrcz deleted the refine-safe-operations branch February 18, 2024 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant