Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the partial evaluation for bit vectors #176

Merged
merged 8 commits into from
Feb 23, 2024
Merged

Conversation

lsrcz
Copy link
Owner

@lsrcz lsrcz commented Feb 23, 2024

This pull request makes the partial evaluation for bit vectors better. It tries to concatenate the adjacent concrete bit vectors together by maintaining a canonical form and tries to eliminate the select operations if they are selecting on partially concrete vectors.

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 86.62791% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 58.56%. Comparing base (c59feba) to head (0a5928a).

❗ Current head 0a5928a differs from pull request most recent head be0048d. Consider uploading reports for the commit be0048d to get more accurate results

Files Patch % Lines
...rc/Grisette/IR/SymPrim/Data/Prim/PartialEval/BV.hs 86.62% 0 Missing and 23 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #176      +/-   ##
==========================================
+ Coverage   57.24%   58.56%   +1.32%     
==========================================
  Files          70       70              
  Lines        5641     5809     +168     
  Branches      459      484      +25     
==========================================
+ Hits         3229     3402     +173     
+ Misses       1953     1923      -30     
- Partials      459      484      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lsrcz lsrcz merged commit 7471a70 into main Feb 23, 2024
11 checks passed
@lsrcz lsrcz deleted the improve-bv-peval branch February 23, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant