Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add symShiftNegated and symRotateNegated #181

Merged
merged 4 commits into from
Mar 4, 2024
Merged

Conversation

lsrcz
Copy link
Owner

@lsrcz lsrcz commented Mar 4, 2024

The asymmetricity of the range of integral values is making the symShift interface hard to use, especially for unsigned types. This pull request adds negated versions symShiftNegated and symRotateNegated that shifts or rotate in the opposite direction.

@lsrcz lsrcz self-assigned this Mar 4, 2024
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 36.70886% with 50 lines in your changes are missing coverage. Please review.

Project coverage is 58.28%. Comparing base (9494142) to head (3b8381c).

Files Patch % Lines
src/Grisette/IR/SymPrim/Data/SymPrim.hs 39.47% 19 Missing and 4 partials ⚠️
src/Grisette/Core/Data/Class/SymShift.hs 18.18% 0 Missing and 18 partials ⚠️
src/Grisette/Core/Data/Class/SymRotate.hs 58.82% 0 Missing and 7 partials ⚠️
src/Grisette/Core/Data/SomeBV.hs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #181      +/-   ##
==========================================
- Coverage   58.52%   58.28%   -0.25%     
==========================================
  Files          70       70              
  Lines        5816     5880      +64     
  Branches      488      508      +20     
==========================================
+ Hits         3404     3427      +23     
- Misses       1924     1945      +21     
- Partials      488      508      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lsrcz lsrcz merged commit a205d58 into main Mar 4, 2024
18 of 20 checks passed
@lsrcz lsrcz deleted the add-sym-shift-negated branch March 4, 2024 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant