Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more mrg* or sym* variants for the Haskell standard library #182

Merged
merged 10 commits into from
Mar 13, 2024

Conversation

lsrcz
Copy link
Owner

@lsrcz lsrcz commented Mar 12, 2024

This pull request provides mrg* and sym* variants for all the functions that come from the following modules:

  • Control.Monad,
  • Control.Applicative,
  • Data.Functor,
  • Data.Traversable,
  • Data.Foldable,
  • Data.List.

This pull request also modified some constraints to the existing functions, like mrgFmap. This is a breaking change.

This pull request is related to #117.

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 91.45299% with 30 lines in your changes are missing coverage. Please review.

Project coverage is 60.00%. Comparing base (a205d58) to head (66fb80e).

❗ Current head 66fb80e differs from pull request most recent head 23164bf. Consider uploading reports for the commit 23164bf to get more accurate results

Files Patch % Lines
src/Grisette/Lib/Control/Monad.hs 84.37% 8 Missing and 2 partials ⚠️
src/Grisette/Core/Data/Class/SOrd.hs 75.00% 6 Missing ⚠️
src/Grisette/Lib/Data/Foldable.hs 94.11% 4 Missing ⚠️
src/Grisette/Core/Control/Monad/UnionM.hs 82.35% 3 Missing ⚠️
src/Grisette/Core/Data/Class/SafeLinearArith.hs 75.00% 3 Missing ⚠️
src/Grisette/Core/Data/Class/PlainUnion.hs 50.00% 2 Missing ⚠️
src/Grisette/Lib/Data/List.hs 99.06% 0 Missing and 1 partial ⚠️
src/Grisette/Lib/Data/Traversable.hs 90.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #182      +/-   ##
==========================================
+ Coverage   58.28%   60.00%   +1.72%     
==========================================
  Files          70       72       +2     
  Lines        5880     6149     +269     
  Branches      508      506       -2     
==========================================
+ Hits         3427     3690     +263     
- Misses       1945     1953       +8     
+ Partials      508      506       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lsrcz lsrcz merged commit e8962c3 into main Mar 13, 2024
11 checks passed
@lsrcz lsrcz deleted the add-some-mrg-functions branch March 13, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant