Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deriving for void types for builtin type classes #191

Merged
merged 1 commit into from Apr 13, 2024

Conversation

lsrcz
Copy link
Owner

@lsrcz lsrcz commented Apr 13, 2024

This pull request adds missing deriving for void types for the builtin types classes.

@lsrcz lsrcz force-pushed the add-deriving-for-void-types branch from e186c7c to 4ee0d3d Compare April 13, 2024 06:45
@lsrcz lsrcz added bug Something isn't working API addition (PVP minor) labels Apr 13, 2024
@lsrcz lsrcz self-assigned this Apr 13, 2024
Copy link

codecov bot commented Apr 13, 2024

Codecov Report

Attention: Patch coverage is 44.44444% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 60.04%. Comparing base (5751b05) to head (e186c7c).

❗ Current head e186c7c differs from pull request most recent head 4ee0d3d. Consider uploading reports for the commit 4ee0d3d to get more accurate results

Files Patch % Lines
src/Grisette/Core/Data/Class/EvaluateSym.hs 80.00% 1 Missing ⚠️
src/Grisette/Core/Data/Class/ExtractSymbolics.hs 0.00% 1 Missing ⚠️
src/Grisette/Core/Data/Class/SubstituteSym.hs 0.00% 1 Missing ⚠️
src/Grisette/Core/Data/Class/ToCon.hs 0.00% 1 Missing ⚠️
src/Grisette/Core/Data/Class/ToSym.hs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #191      +/-   ##
==========================================
- Coverage   60.04%   60.04%   -0.01%     
==========================================
  Files          72       72              
  Lines        6165     6172       +7     
  Branches      504      502       -2     
==========================================
+ Hits         3702     3706       +4     
- Misses       1959     1964       +5     
+ Partials      504      502       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lsrcz lsrcz merged commit afe26ab into main Apr 13, 2024
13 checks passed
@lsrcz lsrcz deleted the add-deriving-for-void-types branch April 13, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API addition (PVP minor) bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant