Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract the Identifier and Symbol types #192

Merged
merged 8 commits into from
Apr 15, 2024
Merged

Conversation

lsrcz
Copy link
Owner

@lsrcz lsrcz commented Apr 15, 2024

This pull request introduces the Identifier and Symbol types for a more consistent representation.

It also reintroduced the identifiers with arbitrary information.

This pull request also refactored the interned terms to remove the cyclic dependency, which prevents CI build.

@lsrcz lsrcz force-pushed the reintroduce-symbol-with-info branch from 9194c3e to e77bd8d Compare April 15, 2024 01:04
Copy link

codecov bot commented Apr 15, 2024

Codecov Report

Attention: Patch coverage is 44.61078% with 185 lines in your changes are missing coverage. Please review.

Project coverage is 59.78%. Comparing base (afe26ab) to head (7d070da).

Files Patch % Lines
...Grisette/IR/SymPrim/Data/Prim/InternedTerm/Term.hs 53.12% 51 Missing and 39 partials ⚠️
src/Grisette/Core/Data/Symbol.hs 22.64% 40 Missing and 1 partial ⚠️
src/Grisette/Core/Data/Class/GenSym.hs 16.66% 30 Missing ⚠️
src/Grisette/IR/SymPrim/Data/Prim/GeneralFun.hs 51.72% 12 Missing and 2 partials ⚠️
src/Grisette/Backend/SBV/Data/SMT/Lowering.hs 66.66% 3 Missing and 1 partial ⚠️
...tte/IR/SymPrim/Data/Prim/InternedTerm/TermUtils.hs 0.00% 3 Missing ⚠️
src/Grisette/Core/Data/Class/Solvable.hs 50.00% 2 Missing ⚠️
src/Grisette/Core/Data/SomeBV.hs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #192      +/-   ##
==========================================
- Coverage   60.01%   59.78%   -0.23%     
==========================================
  Files          72       71       -1     
  Lines        6172     6224      +52     
  Branches      504      504              
==========================================
+ Hits         3704     3721      +17     
- Misses       1964     1999      +35     
  Partials      504      504              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lsrcz lsrcz merged commit 699151e into main Apr 15, 2024
18 of 20 checks passed
@lsrcz lsrcz deleted the reintroduce-symbol-with-info branch April 15, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant