Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New bitvector interface with hidden type-level length #41

Merged
merged 16 commits into from Feb 3, 2023
Merged

Conversation

lsrcz
Copy link
Owner

@lsrcz lsrcz commented Jan 31, 2023

This pull request introduces new bitvector interface:

  1. Bitvector operations are now captured by two type classes: SizedBV and BV. The SizedBV class captures the size-tagged bitvector interface. It enforces the correct size at compile time. The BV class captures the interface for the bitvectors with hidden compile-time sizes.
  2. SomeIntN, SomeWordN, SomeSymIntN and SomeSymWordN are bitvectors with hidden compile-time sizes.
  3. Sym Bool, Sym Integer, etc. are no longer available. The user should only use SymBool, SymInteger, etc.

@codecov
Copy link

codecov bot commented Feb 1, 2023

Codecov Report

Base: 35.79% // Head: 33.25% // Decreases project coverage by -2.54% ⚠️

Coverage data is based on head (a301c96) compared to base (431f7c1).
Patch coverage: 24.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #41      +/-   ##
==========================================
- Coverage   35.79%   33.25%   -2.54%     
==========================================
  Files          47       47              
  Lines        4118     4333     +215     
  Branches      244      217      -27     
==========================================
- Hits         1474     1441      -33     
- Misses       2400     2675     +275     
+ Partials      244      217      -27     
Impacted Files Coverage Δ
src/Grisette/Core/Control/Monad/UnionM.hs 10.61% <ø> (+0.34%) ⬆️
src/Grisette/Core/Data/Class/BitVector.hs 0.00% <0.00%> (ø)
src/Grisette/Core/Data/Class/ModelOps.hs 100.00% <ø> (ø)
src/Grisette/Core/Data/Union.hs 46.15% <ø> (ø)
...Grisette/IR/SymPrim/Data/Prim/InternedTerm/Term.hs 48.41% <0.00%> (+0.82%) ⬆️
...tte/IR/SymPrim/Data/Prim/InternedTerm/TermUtils.hs 36.67% <0.00%> (ø)
...te/IR/SymPrim/Data/Prim/PartialEval/PartialEval.hs 40.00% <ø> (ø)
src/Grisette/IR/SymPrim/Data/BV.hs 35.40% <4.76%> (-32.13%) ⬇️
src/Grisette/Backend/SBV/Data/SMT/Lowering.hs 37.56% <10.52%> (-1.22%) ⬇️
src/Grisette/Core/Data/Class/GenSym.hs 3.51% <16.66%> (-1.33%) ⬇️
... and 22 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lsrcz lsrcz merged commit fb13538 into main Feb 3, 2023
@lsrcz lsrcz deleted the feat-bv-interface branch February 3, 2023 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant