Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix merging for SomeSymBV #72

Merged
merged 1 commit into from
May 15, 2023
Merged

Fix merging for SomeSymBV #72

merged 1 commit into from
May 15, 2023

Conversation

lsrcz
Copy link
Owner

@lsrcz lsrcz commented May 15, 2023

We should allow SomeSymBV with different bit size coexists in a union. This pull request supports this.

@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.11 ⚠️

Comparison is base (71ed075) 32.50% compared to head (ad72121) 32.39%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #72      +/-   ##
==========================================
- Coverage   32.50%   32.39%   -0.11%     
==========================================
  Files          49       49              
  Lines        5006     5016      +10     
  Branches      245      247       +2     
==========================================
- Hits         1627     1625       -2     
- Misses       3134     3144      +10     
- Partials      245      247       +2     
Impacted Files Coverage Δ
src/Grisette/Core/Control/Monad/UnionM.hs 10.82% <ø> (+0.11%) ⬆️
src/Grisette/Core/Data/Class/Mergeable.hs 15.62% <0.00%> (-0.80%) ⬇️
src/Grisette/Core/Data/Class/SimpleMergeable.hs 6.80% <ø> (+0.09%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lsrcz lsrcz merged commit 8fc6f2c into main May 15, 2023
25 of 30 checks passed
@lsrcz lsrcz deleted the fix-dynbv-merge branch June 6, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant