Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tickets/dm 31945 #8

Merged
merged 18 commits into from Feb 8, 2022
Merged

Tickets/dm 31945 #8

merged 18 commits into from Feb 8, 2022

Conversation

MelissaGraham
Copy link
Collaborator

TallJimbo
TallJimbo approved these changes Jan 21, 2022
View reviewed changes
Copy link
Member

@TallJimbo TallJimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - all of my PR comments are tiny style/grammar things.

One general formatting issue: unless LaTeX technotes have some secret sauce I'm not aware of, there are a lot of plain double-quotes that won't render properly.

DMTN-049.tex Outdated Show resolved Hide resolved
DMTN-049.tex Outdated Show resolved Hide resolved
DMTN-049.tex Outdated Show resolved Hide resolved
DMTN-049.tex Outdated Show resolved Hide resolved
DMTN-049.tex Outdated Show resolved Hide resolved
MelissaGraham and others added 5 commits January 21, 2022 14:02
@MelissaGraham @TallJimbo
Update DMTN-049.tex
4036b2b 
Co-authored-by: Jim Bosch <jbosch@astro.princeton.edu>
@MelissaGraham @TallJimbo
Update DMTN-049.tex
82a19b5 
Co-authored-by: Jim Bosch <jbosch@astro.princeton.edu>
@MelissaGraham @TallJimbo
Update DMTN-049.tex
1a97330 
Co-authored-by: Jim Bosch <jbosch@astro.princeton.edu>
@MelissaGraham @TallJimbo
Update DMTN-049.tex
4ec8407 
Co-authored-by: Jim Bosch <jbosch@astro.princeton.edu>
@MelissaGraham @TallJimbo
Update DMTN-049.tex
3f90a04 
Co-authored-by: Jim Bosch <jbosch@astro.princeton.edu>
@MelissaGraham
Copy link
Collaborator Author

One general formatting issue: unless LaTeX technotes have some secret sauce I'm not aware of, there are a lot of plain double-quotes that won't render properly.

They render ok but they do kind of point backwards -- will fix.

leannep
leannep requested changes Feb 4, 2022
View reviewed changes
Copy link
Contributor

@leannep leannep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - a few comments.

DMTN-049.tex Show resolved Hide resolved
DMTN-049.tex Outdated Show resolved Hide resolved
DMTN-049.tex Outdated Show resolved Hide resolved
@MelissaGraham MelissaGraham merged commit c6a223f into main Feb 8, 2022
@MelissaGraham MelissaGraham deleted the tickets/DM-31945 branch February 8, 2022 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TallJimbo TallJimbo TallJimbo approved these changes

@leannep leannep leannep approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MelissaGraham @TallJimbo @leannep